You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4cxx-dev@logging.apache.org by "Edstrom, Chris" <ch...@cisco.com> on 2006/03/10 23:54:12 UTC

Suggested (trivial) patch: Mac OS X non wide-char build issue

Hey all--

I've been trying to compile CVS HEAD of log4cxx for Mac OS X using:

ant -Dhas.wchar_t=0

which gives me the error

/logging-log4cxx/src/systemerrwriter.cpp:52: error: expected declaration
before '}' token

systemerrwriter.cpp seems to have a problem with the #ifdefs, so here's
a patch which fixes my issue:

(I didn't see a JIRA issue which addresses this problem; if this patch
is accepted, I can create one)

Index: systemerrwriter.cpp
===================================================================
--- systemerrwriter.cpp (revision 384939)
+++ systemerrwriter.cpp (working copy)
@@ -48,5 +48,7 @@
 #endif
        LOG4CXX_ENCODE_CHAR(msg, str);
         fputs(msg.c_str(), stderr);
+#if LOG4CXX_HAS_WCHAR_T
     }
+#endif
 }

The issue is simply that the '{' of the else clause if ifdef'ed out, but
the '}' remains. 

--Chris