You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/30 22:52:42 UTC
Review Request: Added keys() to Multimap and multihashmap.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10206/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See above. This is useful because foreachkey will iterate over all non-unique keys.
Diffs
-----
third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp 005f977f995a9c868d3f52cb3674054f445cc081
third_party/libprocess/third_party/stout/include/stout/multimap.hpp a7ad52f4be928d25e1031381007db49e7be91061
third_party/libprocess/third_party/stout/tests/multimap_tests.cpp 6606112647a01a685628005f1d7daf565b87458c
Diff: https://reviews.apache.org/r/10206/diff/
Testing
-------
make check (with added test).
Thanks,
Ben Mahler
Re: Review Request: Added keys() to Multimap and multihashmap.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10206/
-----------------------------------------------------------
(Updated April 9, 2013, 5:46 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Rebased.
Description
-------
See above. This is useful because foreachkey will iterate over all non-unique keys.
Diffs (updated)
-----
third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp 4351f8028007fabee7aa28389de91c28d64213fe
third_party/libprocess/third_party/stout/include/stout/multimap.hpp a7ad52f4be928d25e1031381007db49e7be91061
third_party/libprocess/third_party/stout/tests/multimap_tests.cpp 6606112647a01a685628005f1d7daf565b87458c
Diff: https://reviews.apache.org/r/10206/diff/
Testing
-------
make check (with added test).
Thanks,
Ben Mahler
Re: Review Request: Added keys() to Multimap and multihashmap.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10206/#review18764
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 30, 2013, 9:52 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10206/
> -----------------------------------------------------------
>
> (Updated March 30, 2013, 9:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above. This is useful because foreachkey will iterate over all non-unique keys.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp 005f977f995a9c868d3f52cb3674054f445cc081
> third_party/libprocess/third_party/stout/include/stout/multimap.hpp a7ad52f4be928d25e1031381007db49e7be91061
> third_party/libprocess/third_party/stout/tests/multimap_tests.cpp 6606112647a01a685628005f1d7daf565b87458c
>
> Diff: https://reviews.apache.org/r/10206/diff/
>
>
> Testing
> -------
>
> make check (with added test).
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added keys() to Multimap and multihashmap.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10206/#review18855
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 30, 2013, 9:52 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10206/
> -----------------------------------------------------------
>
> (Updated March 30, 2013, 9:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above. This is useful because foreachkey will iterate over all non-unique keys.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/multihashmap.hpp 005f977f995a9c868d3f52cb3674054f445cc081
> third_party/libprocess/third_party/stout/include/stout/multimap.hpp a7ad52f4be928d25e1031381007db49e7be91061
> third_party/libprocess/third_party/stout/tests/multimap_tests.cpp 6606112647a01a685628005f1d7daf565b87458c
>
> Diff: https://reviews.apache.org/r/10206/diff/
>
>
> Testing
> -------
>
> make check (with added test).
>
>
> Thanks,
>
> Ben Mahler
>
>