You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/02 12:12:02 UTC
[I] [BUG] Exponential/Fixed retry strategies: outer timeout neuters configured retry count [shenyu]
Aias00 opened a new issue, #6583:
URL: https://github.com/apache/shenyu/issues/6583
## Description
The `response` Mono passed in is already wrapped with `.timeout(duration)` in `AbstractHttpClientPlugin` (per-attempt timeout). Then the retry strategy wraps the ENTIRE retry chain in another `.timeout(duration)`. With `duration=3s` and `Retry.fixedDelay(3, Duration.ofSeconds(2))`, the outer 3s timeout fires before the 2s delay completes, so an operator configuring `retryTimes=3` actually gets at most 1 retry. (Counterpart: `DefaultRetryStrategy` "current" mode has NO outer timeout on the retry chain, so with `retryTimes=5` and `maxBackoff=20s` a dead-upstream request can occupy a connection for up to ~115s — slow-death amplification.)
## Location
```
shenyu-plugin-httpclient/.../ExponentialRetryBackoffStrategy.java:53-54
FixedRetryStrategy.java:52-53
```
## Impact
Configured retry counts are silently ineffective (Exponential/Fixed), or unbounded connection occupation (Default "current").
## Suggested fix
Use a separate, longer timeout for the retry chain (e.g. `duration * (retryTimes + 1)` + backoff), or remove the inner per-attempt timeout and let the chain's outer timeout be the sole bound. Add an outer deadline to the DefaultRetryStrategy "current" mode.
## Related existing issue(s)
None
_Identified during the 2026-08-02 audit; full list in [`docs/issue-candidates-2026-08-02.md`](docs/issue-candidates-2026-08-02.md)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] Exponential/Fixed retry strategies: outer timeout neuters configured retry count [shenyu]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6583:
URL: https://github.com/apache/shenyu/issues/6583#issuecomment-5157759840
👋 Hello @yuluo-yx
A new issue has been opened by @Aias00:
- **Title**: [BUG] Exponential/Fixed retry strategies: outer timeout neuters configured retry count
- **Link**: https://github.com/apache/shenyu/issues/6583
Please review when you have time. Thank you! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] Exponential/Fixed retry strategies: outer timeout neuters configured retry count [shenyu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #6583: [BUG] Exponential/Fixed retry strategies: outer timeout neuters configured retry count
URL: https://github.com/apache/shenyu/issues/6583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org