[GitHub] [pulsar] Technoboy- commented on a change in pull request #11150: Fix Flaky-test: [LoadBalancerTest].[testBrokerRanking]

[GitBox <gi...@apache.org>]

Technoboy- commented on a change in pull request #11150:
URL: https://github.com/apache/pulsar/pull/11150#discussion_r661233845



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/SimpleLoadManagerImpl.java
##########
@@ -319,7 +323,7 @@ private String getDynamicConfigurationFromStore(String path, String settingName,
     private double getDynamicConfigurationDouble(String path, String settingName, double defaultValue) {
         double result = defaultValue;
         try {
-            String setting = this.getDynamicConfigurationFromStore(path, settingName, null);
+            String setting = this.getDynamicConfigurationFromStore(path, settingName, String.valueOf(defaultValue));

Review comment:
       Ok, I will split this patch. And pull a new request for test getDynamicConfigurationBoolean.
   Thanks for reviewing .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org