You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/12/06 00:28:36 UTC
Review Request 28777: Remove dead source file (not referenced in
makefile)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28777/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
File is not in Makefile and removing it doesn't affect the build.
Diffs
-----
3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
Diff: https://reviews.apache.org/r/28777/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 28777: Remove dead source file (not referenced in
makefile)
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28777/#review64145
-----------------------------------------------------------
Patch looks great!
Reviews applied: [28777]
All tests passed.
- Mesos ReviewBot
On Dec. 5, 2014, 11:28 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28777/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 11:28 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> File is not in Makefile and removing it doesn't affect the build.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
>
> Diff: https://reviews.apache.org/r/28777/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 28777: Remove dead source file (not referenced in
makefile)
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28777/#review64156
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Dec. 5, 2014, 11:28 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28777/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2014, 11:28 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> File is not in Makefile and removing it doesn't affect the build.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/httpd.cpp 902ba89b18c5d7edf68ca9d17c55e5727529f96e
>
> Diff: https://reviews.apache.org/r/28777/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>