You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/15 21:46:41 UTC

[jira] [Commented] (KAFKA-438) Code cleanup in MessageTest

    [ https://issues.apache.org/jira/browse/KAFKA-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970161#comment-15970161 ] 

ASF GitHub Bot commented on KAFKA-438:
--------------------------------------

GitHub user jozi-k opened a pull request:

    https://github.com/apache/kafka/pull/2858

    KAFKA-438: Code cleanup in MessageTest

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jozi-k/kafka MessageTest-code-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2858.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2858
    
----
commit f5975183306e42e2881fd01de80dad65df628d33
Author: Jozef Koval <jo...@protonmail.ch>
Date:   2017-04-15T21:43:24Z

    KAFKA-438: Code cleanup in MessageTest

----


> Code cleanup in MessageTest
> ---------------------------
>
>                 Key: KAFKA-438
>                 URL: https://issues.apache.org/jira/browse/KAFKA-438
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 0.7.1
>            Reporter: Jim Plush
>            Priority: Trivial
>         Attachments: KAFKA-438
>
>
> While exploring the Unit Tests this class had an unused import statement, some ambiguity on which HashMap implementation was being used and assignments of function returns when not required. 
> Trivial stuff



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)