You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2023/07/21 02:54:18 UTC
[GitHub] [pulsar] nodece commented on a diff in pull request #20268: [feat] Enable hostname verification by default
nodece commented on code in PR #20268:
URL: https://github.com/apache/pulsar/pull/20268#discussion_r1270178172
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java:
##########
@@ -780,12 +780,9 @@ class LocalRunner extends FunctionDetailsCommand {
@Parameter(names = "--tls-allow-insecure", description = "Allow insecure tls connection #Java, Python")
protected boolean tlsAllowInsecureConnection;
// for backwards compatibility purposes
- @Parameter(names = "--hostname_verification_enabled",
- description = "Enable hostname verification", hidden = true)
- protected Boolean deprecatedTlsHostNameVerificationEnabled = null;
@Parameter(names = "--hostname-verification-enabled", description = "Enable hostname verification"
- + " #Java, Python")
- protected boolean tlsHostNameVerificationEnabled;
+ + " #Java, Python", arity = 1)
+ protected boolean tlsHostNameVerificationEnabled = true;
Review Comment:
It seems we should keep the `--hostname_verification_enabled` flag for backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org