You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by subhash-koganti <gi...@git.apache.org> on 2017/10/06 05:30:35 UTC

[GitHub] incubator-netbeans pull request #65: Added Apache License

GitHub user subhash-koganti opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/65

    Added Apache License

    - no external libraries
    - checked Rat report and found 11 XML files that don't have any license info defined on them. Added the license text on to them . 
    - After adding the text , Recompiled the code and ran the rat report again and Made sure that these files are fixed in the rat report .
    - skimmed through the module, did not notice any additional problems

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/subhash-koganti/incubator-netbeans master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/65.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #65
    
----
commit 72821a5b06ce6ebf16820585af4eccfbe582b03a
Author: subhash-koganti <su...@gmail.com>
Date:   2017-10-06T05:10:50Z

    Added Apache License

----


---

[GitHub] incubator-netbeans issue #65: Modules Review - [editor.settings.lib] Added A...

Posted by subhash-koganti <gi...@git.apache.org>.

Github user subhash-koganti commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/65
  
    Just submitted a Pull Request 66 with the fixed commit.


---

[GitHub] incubator-netbeans issue #65: Modules Review - [editor.settings.lib] Added A...

Posted by junichi11 <gi...@git.apache.org>.

Github user junichi11 commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/65
  
    You should also fix the commit message. In your case, `[NETBEANS-54] Module Review editor.settings.lib`
    
    see [List of Modules to Review](https://cwiki.apache.org/confluence/display/NETBEANS/List+of+Modules+to+Review):
    > When done commit the changes with a commit message that starts with first line "[NETBEANS-54] Module Review `<module>`" (`<module>` should be replaced with the module you reviewed) and a message body describing your review, see the comments section below for samples. The changeset should then be proposed for merging via a PR.
    
    Thanks.



---

[GitHub] incubator-netbeans pull request #65: Modules Review - [editor.settings.lib] ...

Posted by subhash-koganti <gi...@git.apache.org>.

Github user subhash-koganti closed the pull request at:

    https://github.com/apache/incubator-netbeans/pull/65


---

[GitHub] incubator-netbeans issue #65: Modules Review - [editor.settings.lib] Added A...

Posted by subhash-koganti <gi...@git.apache.org>.

Github user subhash-koganti commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/65
  
    Ohk. I will submit a new Pull request with the updated Commit Message. 
    Thanks for the review. 


---