[Bug 4900] Persistent blacklist not really persistent

[bu...@issues.apache.org]

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=4900

--- Comment #4 from Mark Martinec <Ma...@ijs.si> 2010-04-13 06:15:12 EDT ---
Bug 6032, Ian Turner 2008-12-18 :

These commands (--add-addr-to-blacklist and --add-addr-to-whitelist) just set
the AWL database with count=1 and totscore equal to to plus or minus 100. But
since the count is set to 1, the average score quickly returns to the mean
typical for messages from this source.

For example, consider a message sender whitehat@example.com, whose messages are
flagged as spam with score 30. Assume the system is configured with a spam
threshold of 10. Finally, assume an administrator runs spamassassin
--add-addr-to-whitelist=whitehat@example.com and that several messages are then
recieved from this source. We will see the following behaviour:

Message       pre-AWL     post-AWL    count   totscore   Message accepted?
               score       score
                                        1       -100
      1          30          -35        2        -70      TRUE
      2          30          -20        3        -40      TRUE
      3          30           -5        4        -10      TRUE
      4          30           10        5         20      FALSE
      5          30           25        6         50      FALSE

As it turns out, the --add-addr-to-whitelist command was only good for three
messages.

In my opinion, the easy way to fix this bug is to set totscore=100000 and
score=1000, but the best way is to probably have a scheme where if count is
null then totscore is never changed, and to set count=null when adding known
addresses.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.