You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Klues <kl...@gmail.com> on 2016/12/04 07:35:18 UTC

Review Request 54348: Fixed small bug in `IOSwitchboardServerProcess::acceptLoop()`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54348/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Repository: mesos


Description
-------

Fixed small bug in `IOSwitchboardServerProcess::acceptLoop()`.


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.cpp 778367a268ec350ed438bc9fe9d359d63bdb5503 

Diff: https://reviews.apache.org/r/54348/diff/


Testing
-------

```
GTEST_FILTER="" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
```


Thanks,

Kevin Klues


Re: Review Request 54348: Fixed small bug in `IOSwitchboardServerProcess::acceptLoop()`.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54348/#review157929
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Dec. 4, 2016, 7:35 a.m., Kevin Klues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54348/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2016, 7:35 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed small bug in `IOSwitchboardServerProcess::acceptLoop()`.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp 778367a268ec350ed438bc9fe9d359d63bdb5503 
> 
> Diff: https://reviews.apache.org/r/54348/diff/
> 
> 
> Testing
> -------
> 
> ```
> GTEST_FILTER="" make -j check
> GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
> ```
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>


Re: Review Request 54348: Fixed small bug in `IOSwitchboardServerProcess::acceptLoop()`.

Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54348/
-----------------------------------------------------------

(Updated Dec. 5, 2016, 7:09 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Rebased on master.


Repository: mesos


Description
-------

Fixed small bug in `IOSwitchboardServerProcess::acceptLoop()`.


Diffs (updated)
-----

  src/slave/containerizer/mesos/io/switchboard.cpp d5211b98616e72a27ca6b472a5ee83505c227f22 

Diff: https://reviews.apache.org/r/54348/diff/


Testing
-------

```
GTEST_FILTER="" make -j check
GTEST_FILTER="*IOSwitchboard*" src/mesos-tests
```


Thanks,

Kevin Klues