You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/23 05:33:40 UTC

[GitHub] [apisix] idbeta opened a new pull request #3639: test: add fuzzing case for the route with serverless-post-function

idbeta opened a new pull request #3639:
URL: https://github.com/apache/apisix/pull/3639


   ### What this PR does / why we need it:
   relate #3340
   fuzzing for the route with `post` and `serverless-post-function`
   
   ### Pre-submission checklist:
   
   * [x] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] idbeta commented on pull request #3639: test: add fuzzing case for the route with serverless-post-function

Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #3639:
URL: https://github.com/apache/apisix/pull/3639#issuecomment-784040427


   ping @spacewander @moonming @membphis 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] idbeta commented on a change in pull request #3639: test: add fuzzing case for the route with serverless-post-function

Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #3639:
URL: https://github.com/apache/apisix/pull/3639#discussion_r580989001



##########
File path: .github/workflows/fuzzing-ci.yaml
##########
@@ -51,9 +51,13 @@ jobs:
       run: |
         pip install typing boofuzz
 
-    - name: run test
+    - name: run simpleroute test
       run: |
-        python $PWD/t/fuzzing/route_test.py
+        python $PWD/t/fuzzing/simpleroute_test.py
+
+    - name: run serverless route test

Review comment:
       I think this should be clearer. what do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on a change in pull request #3639: test: add fuzzing case for the route with serverless-post-function

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3639:
URL: https://github.com/apache/apisix/pull/3639#discussion_r580967031



##########
File path: .github/workflows/fuzzing-ci.yaml
##########
@@ -51,9 +51,13 @@ jobs:
       run: |
         pip install typing boofuzz
 
-    - name: run test
+    - name: run simpleroute test
       run: |
-        python $PWD/t/fuzzing/route_test.py
+        python $PWD/t/fuzzing/simpleroute_test.py
+
+    - name: run serverless route test

Review comment:
       Why put it into separate step?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] spacewander commented on a change in pull request #3639: test: add fuzzing case for the route with serverless-post-function

Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #3639:
URL: https://github.com/apache/apisix/pull/3639#discussion_r581017249



##########
File path: .github/workflows/fuzzing-ci.yaml
##########
@@ -51,9 +51,13 @@ jobs:
       run: |
         pip install typing boofuzz
 
-    - name: run test
+    - name: run simpleroute test
       run: |
-        python $PWD/t/fuzzing/route_test.py
+        python $PWD/t/fuzzing/simpleroute_test.py
+
+    - name: run serverless route test

Review comment:
       I see.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] idbeta commented on pull request #3639: test: add fuzzing case for the route with serverless-post-function

Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #3639:
URL: https://github.com/apache/apisix/pull/3639#issuecomment-784704365


   ping @membphis 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix] membphis merged pull request #3639: test: add fuzzing case for the route with serverless-post-function

Posted by GitBox <gi...@apache.org>.
membphis merged pull request #3639:
URL: https://github.com/apache/apisix/pull/3639


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org