You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by dk...@apache.org on 2023/06/13 17:40:17 UTC

[cxf] branch main updated: Fix checkstyle

This is an automated email from the ASF dual-hosted git repository.

dkulp pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cxf.git


The following commit(s) were added to refs/heads/main by this push:
     new 40ad295ad0 Fix checkstyle
40ad295ad0 is described below

commit 40ad295ad0fb5cb856cd97b260f10ce2a53a526b
Author: Daniel Kulp <da...@kulp.com>
AuthorDate: Tue Jun 13 13:39:28 2023 -0400

    Fix checkstyle
---
 .../apache/cxf/transport/http/HttpClientHTTPConduit.java |  5 +----
 .../apache/cxf/systest/jaxws/JaxWsClientThreadTest.java  | 16 ++++++++--------
 2 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java b/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java
index af7c81b2ec..f836903431 100644
--- a/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java
+++ b/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java
@@ -25,7 +25,6 @@ import java.io.OutputStream;
 import java.io.PipedInputStream;
 import java.io.PipedOutputStream;
 import java.io.PushbackInputStream;
-import java.lang.reflect.InvocationTargetException;
 import java.net.ConnectException;
 import java.net.HttpURLConnection;
 import java.net.MalformedURLException;
@@ -34,7 +33,6 @@ import java.net.ProxySelector;
 import java.net.SocketAddress;
 import java.net.URI;
 import java.net.URISyntaxException;
-import java.net.URLConnection;
 import java.net.UnknownHostException;
 import java.net.http.HttpClient;
 import java.net.http.HttpClient.Redirect;
@@ -73,7 +71,6 @@ import javax.net.ssl.SSLSession;
 
 import org.apache.cxf.Bus;
 import org.apache.cxf.common.util.PropertyUtils;
-import org.apache.cxf.common.util.ReflectionUtil;
 import org.apache.cxf.configuration.jsse.TLSClientParameters;
 import org.apache.cxf.helpers.HttpHeaderHelper;
 import org.apache.cxf.helpers.JavaUtils;
@@ -137,7 +134,7 @@ public class HttpClientHTTPConduit extends URLConnectionHTTPConduit {
         }
         try {        
             ThreadGroup rootGroup = Thread.currentThread().getThreadGroup();
-            Thread threads[] = new Thread[rootGroup.activeCount()];
+            Thread[] threads = new Thread[rootGroup.activeCount()];
             int cnt = rootGroup.enumerate(threads);
             for (int x = 0; x < cnt; x++) {
                 if (threads[x].getName().contains(n)) {
diff --git a/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/JaxWsClientThreadTest.java b/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/JaxWsClientThreadTest.java
index 223faba554..d437e6a8a8 100644
--- a/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/JaxWsClientThreadTest.java
+++ b/systests/jaxws/src/test/java/org/apache/cxf/systest/jaxws/JaxWsClientThreadTest.java
@@ -237,15 +237,15 @@ public class JaxWsClientThreadTest extends AbstractCXFTest {
         int start = rootGroup.activeCount();
 
         Thread[] threads = new Thread[numThreads];
-        for (int i = 0; i < numThreads; i++) {
-            final int tid = i;
+        for (int t = 0; t < numThreads; t++) {
+            final int tid = t;
             Runnable r = new Runnable() {
                 public void run() {
                     final Greeter greeter = s.getPort(portName, Greeter.class);
-                    try (AutoCloseable c = (AutoCloseable)greeter){
+                    try (AutoCloseable c = (AutoCloseable)greeter) {
                         final InvocationHandler handler = Proxy.getInvocationHandler(greeter);
-                        Map<String, Object> requestContext = ((BindingProvider)handler).getRequestContext();                        
-                        
+                        Map<String, Object> requestContext = ((BindingProvider)handler).getRequestContext();
+
                         final String protocol = "http-" + Thread.currentThread().getId();
                         for (int i = 0; i < 10; i++) {
                             String threadSpecificaddress = protocol + "://localhost:80/" + i;
@@ -277,7 +277,7 @@ public class JaxWsClientThreadTest extends AbstractCXFTest {
                     }
                 }
             };
-            threads[i] = new Thread(r);
+            threads[t] = new Thread(r);
         }
         for (int i = 0; i < numThreads; i++) {
             threads[i].start();
@@ -301,8 +301,8 @@ public class JaxWsClientThreadTest extends AbstractCXFTest {
         
         
         System.out.println("Start: " + start + "     End: " + end);
-        // we'll allow a few extra threads to be created for various things like GC, but we definitely shouldn't be anywhere 
-        // near numThreads of extra threads
+        // we'll allow a few extra threads to be created for various things like GC, but we
+        // definitely shouldn't be anywhere near numThreads of extra threads
         assertTrue("Too many extra trheads created  " + end + "/" + start, (end - start) < 5);
 
     }