[GitHub] [pulsar] Anonymitaet commented on a change in pull request #7251: [pulsar-admin] Fix tenant admin should be able to get tenant-info

[GitBox <gi...@apache.org>]

Anonymitaet commented on a change in pull request #7251:
URL: https://github.com/apache/pulsar/pull/7251#discussion_r551895241



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java
##########
@@ -76,7 +76,7 @@
     public TenantInfo getTenantAdmin(
         @ApiParam(value = "The tenant name")
         @PathParam("tenant") String tenant) {
-        validateSuperUserAccess();
+        validateAdminAccessForTenant(tenant);

Review comment:
       Hi @rdhabalia 
   
   Since this code change affects both REST API and pulsar-admin docs, could you please help update the docs in this PR as below? (P.S. I've confirmed this w/ @tuteng) 
   Many thanks~
   
   - REST API
   Go to [TenantsBase.java, Line 69](https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TenantsBase.java#L69), add `This operation requires admin privilege` after `Get the admin configuration for a given tenant.`
   
   - pulsar-admin
   Go to [CmdTenants.java, Line 43](https://github.com/apache/pulsar/blob/master/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTenants.java#L43), add `This operation requires admin privilege` after `Gets the configuration of a tenant.`
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org