You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by JPercivall <gi...@git.apache.org> on 2018/04/17 02:43:44 UTC
[GitHub] nifi pull request #2637: NIFI-5085 In InvokeHttp, moving the OkHttp Response...
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/2637
NIFI-5085 In InvokeHttp, moving the OkHttp Response object to a try w…
…ith resources
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi NIFI-5085_closing_OkHttpResponse_in_InvokeHttp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2637.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2637
----
commit a320601fbd20f9ae77044c9babe2728dc89d6426
Author: Joe Percivall <jp...@...>
Date: 2018-04-17T02:36:26Z
NIFI-5085 In InvokeHttp, moving the OkHttp Response object to a try with resources
----
---
[GitHub] nifi issue #2637: NIFI-5085 In InvokeHttp, moving the OkHttp Response object...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/2637
Will close, thanks for the review @mattyb149!
For linkage: https://github.com/apache/nifi/commit/a0c9bebe241e8960363490cc0378f22d034f8db7
---
[GitHub] nifi issue #2637: NIFI-5085 In InvokeHttp, moving the OkHttp Response object...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2637
@JPercivall I forgot to sign off and put the "This closes" on the commit, do you mind closing this PR? Please and thanks and sorry about that!
---
[GitHub] nifi pull request #2637: NIFI-5085 In InvokeHttp, moving the OkHttp Response...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall closed the pull request at:
https://github.com/apache/nifi/pull/2637
---
[GitHub] nifi issue #2637: NIFI-5085 In InvokeHttp, moving the OkHttp Response object...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2637
+1 LGTM, ran build with unit tests. Thanks for the improvement! Merging to master
---