[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #960: DISPATCH-1886 - Close race window on connection activate/close.

[GitBox <gi...@apache.org>]

ganeshmurthy commented on pull request #960:
URL: https://github.com/apache/qpid-dispatch/pull/960#issuecomment-746575563


   This looks good to me. Every call to qd_server_activate(conn); must be protected by the server->conn_activation_lock. 
   1. The call to qd_server_activate in CORE_connection_activate() (in router_node.c) is already protected by this lock.
   2. This PR removes qd_link_activate()
   3. This PR introduces the lock around qd_server_activate call in qd_connection_invoke_deferred (in server.c)
    


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org