You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/09 08:51:22 UTC
[GitHub] [doris] jackwener opened a new pull request, #13216: [improve](Nereids): split otherJoinCondition with List.
jackwener opened a new pull request, #13216:
URL: https://github.com/apache/doris/pull/13216
# Proposed changes
Issue Number: close #xxx
## Problem summary
split otherJoinCondition with List.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #13216: [improve](Nereids): split otherJoinCondition with List.
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #13216:
URL: https://github.com/apache/doris/pull/13216#discussion_r990880286
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJoin.java:
##########
@@ -45,8 +45,10 @@
public class LogicalJoin<LEFT_CHILD_TYPE extends Plan, RIGHT_CHILD_TYPE extends Plan>
extends LogicalBinary<LEFT_CHILD_TYPE, RIGHT_CHILD_TYPE> implements Join {
+ public static final List<Expression> EMPTY_LIST = ImmutableList.of();
Review Comment:
```suggestion
public static final List<Expression> EMPTY_CONDITIONS = ImmutableList.of();
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/MultiJoin.java:
##########
@@ -133,8 +133,8 @@ private Plan reorderJoinsAccordingToConditions(List<Plan> joinInputs, List<Expre
conjuncts);
List<Expression> joinConditions = pair.first;
List<Expression> nonJoinConditions = pair.second;
- LogicalJoin join = new LogicalJoin<>(JoinType.INNER_JOIN, new ArrayList<>(),
- ExpressionUtils.optionalAnd(joinConditions),
+ LogicalJoin join = new LogicalJoin<>(JoinType.INNER_JOIN, LogicalJoin.EMPTY_LIST,
+ joinConditions,
left, right);
Review Comment:
```suggestion
joinConditions, left, right);
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJoin.java:
##########
@@ -45,8 +45,10 @@
public class LogicalJoin<LEFT_CHILD_TYPE extends Plan, RIGHT_CHILD_TYPE extends Plan>
extends LogicalBinary<LEFT_CHILD_TYPE, RIGHT_CHILD_TYPE> implements Join {
+ public static final List<Expression> EMPTY_LIST = ImmutableList.of();
Review Comment:
btw, we could move it to expression utils since it is general enough
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalJoin.java:
##########
@@ -58,28 +60,39 @@
* @param joinType logical type for join
*/
public LogicalJoin(JoinType joinType, LEFT_CHILD_TYPE leftChild, RIGHT_CHILD_TYPE rightChild) {
- this(joinType, ImmutableList.of(),
- Optional.empty(), Optional.empty(),
+ this(joinType, ImmutableList.of(), EMPTY_LIST, Optional.empty(),
Review Comment:
```suggestion
this(joinType, EMPTY_CONDITIONS, EMPTY_CONDITIONS, Optional.empty(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener merged pull request #13216: [improve](Nereids): split otherJoinCondition with List.
Posted by GitBox <gi...@apache.org>.
jackwener merged PR #13216:
URL: https://github.com/apache/doris/pull/13216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13216: [improve](Nereids): split otherJoinCondition with List.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13216:
URL: https://github.com/apache/doris/pull/13216#issuecomment-1276992829
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13216: [improve](Nereids): split otherJoinCondition with List.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13216:
URL: https://github.com/apache/doris/pull/13216#issuecomment-1276992802
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org