[GitHub] [pulsar] coderzc commented on pull request #17848: [fix][flask-test] Fix and improve LookupRetryTest

[GitBox <gi...@apache.org>]

coderzc commented on PR #17848:
URL: https://github.com/apache/pulsar/pull/17848#issuecomment-1258999303

   > @coderzc although, can you explain a bit about how this patch fix the original issue?
   > 
   > The original failure reports:
   > 
   > ```
   >   Error:  testCloseConnectionOnBrokerRejectedRequest(org.apache.pulsar.client.impl.LookupRetryTest)  Time elapsed: 2.146 s  <<< FAILURE!
   >   java.lang.AssertionError: expected [2] but found [1]
   >   	at org.testng.Assert.fail(Assert.java:99)
   >   	at org.testng.Assert.failNotEquals(Assert.java:1037)
   >   	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
   >   	at org.testng.Assert.assertEquals(Assert.java:122)
   >   	at org.testng.Assert.assertEquals(Assert.java:907)
   >   	at org.testng.Assert.assertEquals(Assert.java:917)
   >   	at org.apache.pulsar.client.impl.LookupRetryTest.testCloseConnectionOnBrokerRejectedRequest(LookupRetryTest.java:217)
   > ```
   > 
   > That doesn't directly related to the hash map.
   
   Oh, I haven't found the root cause of the original case for the time being, but when I have repeatedly executed `testCloseConnectionOnBrokerRejectedRequest` many times, if don‘t clear`failureMap` will cause similar problems.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org