Eric's observation was: 2nd voting candidate for NetBeans HTML/Java API version 1.7

[Jaroslav Tulach <ja...@gmail.com>]

po 4. 11. 2019 v 17:01 odesílatel Eric Barboni <sk...@apache.org> napsal:

> +1 (binding)
> Basic check ok, build ok.
>

Thanks Eric for your review and approval...


>
> Some feedback
> Building
>  pass on jdk 13 windows package goal (tested a Javadoc build , Javadoc api
> doclet somehow not working (maybe we should bump plugin version))
>

Alas, the doclet isn't yet working on JDK13:
https://github.com/jtulach/codesnippet4javadoc/issues/14


>
> Testing.
> Testings are sometimes long I can go through 20/21 modules in the build.
> Not sure on how to make for individual package.
>

```
netbeans-html4j $ mvn install -DskipTests
netbeans-html4j $ cd browser
browser $ mvn test
```


> DukeScript presenter browser do a lots of things in browser, then hang (1
> or 2 server started).
>

Try to close the browser. The process may be waiting for the browser to
finish. This behavior is very OS dependent - ideas how to launch the
browser on your OS, so we don't have to wait for it to finish, is welcomed.
Especially in a form of PR.
-jt


> -----Message d'origine-----
> De : Jaroslav Tulach <ja...@gmail.com>
> Envoyé : lundi 4 novembre 2019 07:11
> À : dev <de...@netbeans.apache.org>
> Objet : [VOTE] 2nd voting candidate for NetBeans HTML/Java API version 1.7
>
> Hi.
> As my first attempt to accommodate the recent donation of various
> presenters by DukeHoff GmbH, and release 1.7 of Apache NetBeans HTML/Java
> API failed with a NOTICE file error and a bug in WebKitPresenterTest, I had
> to prepare new bits. Please find the source at
>
>
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-html4j/netbeans-html4j-1.7/
>
> and the staged Maven artifacts at
> https://repository.apache.org/content/repositories/orgapachenetbeans-1052/
>
> Please evaluate them again and cast your vote during next 72h. The process
> of evaluation is the same as last week.
>
> What can you verify?
>
> ## checksums, signatures, etc.
>
> Obviously those should be correct.
>
> ## if it builds
>
> I used "mvn package -DskipTests" and I believe the compilation shall
> succeed on JDK8, JDK11, JDK13 (Eric reported problem building on JDK13, but
> it works for me).
>
> ## if the tests pass
>
> Use "mvn package". They may not - especially the newly donated modules are
> very sensitive to surrounding environment. Getting them run on all
> important platforms may take some time.
>
> If you want to report your findings, then please include the version of
> operating system, version of JDK, version of the browser, etc. You may also
> want to run them individually. E.g. "mvn -f browser test" or "mvn -f webkit
> test".
>
> I know that browser doesn't seem to run on Windows 8 with Internet
> Explorer (but it runs with Firefox instead). I know that webkit does run on
> Ubuntu
> 18.04 with proper libraries ("libwebkit") installed. But those libraries
> aren't present in Ubuntu 19.10 - there is "libwebkit2" and somebody would
> have to adjust the code to use the "libwebkit2" code. In short, there are
> many broken things in the browser and webkit modules - volunteers welcomed
> to make them run!
>
> ## How to cast your vote?
>
> I propose the goal of 1.7 release to be to compile and execute its tests
> (except browser and webkit modules) on all supported platforms. We should
> collect the test failures in browser and webkit modules and find some
> volunteers to fix them for some upcoming update release.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@netbeans.apache.org
> For additional commands, e-mail: dev-help@netbeans.apache.org
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
>