You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@curator.apache.org by Jordan Zimmerman <jo...@jordanzimmerman.com> on 2017/01/13 15:12:26 UTC
Pull Requests needing review
Hello Folks,
The following Pull Requests could really use review. If you have a moment it would be appreciated:
[CURATOR-200] Shade Guava into Curator - https://github.com/apache/curator/pull/190 <https://github.com/apache/curator/pull/190>
[CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/curator/pull/189 <https://github.com/apache/curator/pull/189>
-Jordan
Re: Pull Requests needing review
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
I had huge hopes for Gradle. I was one of the first users of Gradle at Netflix. But, over time I realized that it’s just Ant with a Groovy wrapper. No thanks.
-JZ
> On Jan 16, 2017, at 3:19 PM, Scott Blum <dr...@gmail.com> wrote:
>
> LOL. I definitely feel the love/hate from maven days. I don't have a
> *conceptual* problem with Maven (except that I wish it were more geared
> towards storing versioned dependencies locally forever), it's the execution
> that's extremely poor. And extending its capabilities is a nightmare.
> Something better could and should exist.
>
> On Sun, Jan 15, 2017 at 9:34 PM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
>
>> I love Maven :D
>>
>> https://rule1.quora.com/Use-Maven-Not-Gradle
>>
>> -JZ
>>
>>
>> On Jan 15, 2017, at 12:36 PM, Scott Blum <dr...@gmail.com> wrote:
>>
>> I glanced at the maven shade one, seemed okay. Maven is such a shit ball
>> though that the rule of thumb is that of the output is right, it's right.
>> Lol
>>
>> On Jan 15, 2017 8:30 AM, "Jordan Zimmerman" <jo...@jordanzimmerman.com>
>> wrote:
>>
>> Thanks Cameron
>>
>> On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mc...@gmail.com>
>>
>> wrote:
>>
>>
>> I've been looking at the CURATOR-99 PR, but it's going to take a while,
>> it's quite a large PR.
>>
>> The Maven shading one, I'm not going to be much use reviewing as my
>> knowledge of Maven is very limited.
>> cheers
>>
>> On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
>> jordan@jordanzimmerman.com> wrote:
>>
>> Hello Folks,
>>
>> The following Pull Requests could really use review. If you have a
>>
>> moment
>>
>> it would be appreciated:
>>
>>
>> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
>> curator/pull/190
>> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
>> curator/pull/189
>>
>>
>> -Jordan
>>
>>
>>
>>
>>
Re: Pull Requests needing review
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
I had huge hopes for Gradle. I was one of the first users of Gradle at Netflix. But, over time I realized that it’s just Ant with a Groovy wrapper. No thanks.
-JZ
> On Jan 16, 2017, at 3:19 PM, Scott Blum <dr...@gmail.com> wrote:
>
> LOL. I definitely feel the love/hate from maven days. I don't have a
> *conceptual* problem with Maven (except that I wish it were more geared
> towards storing versioned dependencies locally forever), it's the execution
> that's extremely poor. And extending its capabilities is a nightmare.
> Something better could and should exist.
>
> On Sun, Jan 15, 2017 at 9:34 PM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
>
>> I love Maven :D
>>
>> https://rule1.quora.com/Use-Maven-Not-Gradle
>>
>> -JZ
>>
>>
>> On Jan 15, 2017, at 12:36 PM, Scott Blum <dr...@gmail.com> wrote:
>>
>> I glanced at the maven shade one, seemed okay. Maven is such a shit ball
>> though that the rule of thumb is that of the output is right, it's right.
>> Lol
>>
>> On Jan 15, 2017 8:30 AM, "Jordan Zimmerman" <jo...@jordanzimmerman.com>
>> wrote:
>>
>> Thanks Cameron
>>
>> On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mc...@gmail.com>
>>
>> wrote:
>>
>>
>> I've been looking at the CURATOR-99 PR, but it's going to take a while,
>> it's quite a large PR.
>>
>> The Maven shading one, I'm not going to be much use reviewing as my
>> knowledge of Maven is very limited.
>> cheers
>>
>> On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
>> jordan@jordanzimmerman.com> wrote:
>>
>> Hello Folks,
>>
>> The following Pull Requests could really use review. If you have a
>>
>> moment
>>
>> it would be appreciated:
>>
>>
>> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
>> curator/pull/190
>> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
>> curator/pull/189
>>
>>
>> -Jordan
>>
>>
>>
>>
>>
Re: Pull Requests needing review
Posted by Scott Blum <dr...@gmail.com>.
LOL. I definitely feel the love/hate from maven days. I don't have a
*conceptual* problem with Maven (except that I wish it were more geared
towards storing versioned dependencies locally forever), it's the execution
that's extremely poor. And extending its capabilities is a nightmare.
Something better could and should exist.
On Sun, Jan 15, 2017 at 9:34 PM, Jordan Zimmerman <
jordan@jordanzimmerman.com> wrote:
> I love Maven :D
>
> https://rule1.quora.com/Use-Maven-Not-Gradle
>
> -JZ
>
>
> On Jan 15, 2017, at 12:36 PM, Scott Blum <dr...@gmail.com> wrote:
>
> I glanced at the maven shade one, seemed okay. Maven is such a shit ball
> though that the rule of thumb is that of the output is right, it's right.
> Lol
>
> On Jan 15, 2017 8:30 AM, "Jordan Zimmerman" <jo...@jordanzimmerman.com>
> wrote:
>
> Thanks Cameron
>
> On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mc...@gmail.com>
>
> wrote:
>
>
> I've been looking at the CURATOR-99 PR, but it's going to take a while,
> it's quite a large PR.
>
> The Maven shading one, I'm not going to be much use reviewing as my
> knowledge of Maven is very limited.
> cheers
>
> On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
>
> Hello Folks,
>
> The following Pull Requests could really use review. If you have a
>
> moment
>
> it would be appreciated:
>
>
> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
> curator/pull/190
> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
> curator/pull/189
>
>
> -Jordan
>
>
>
>
>
Re: Pull Requests needing review
Posted by Scott Blum <dr...@gmail.com>.
LOL. I definitely feel the love/hate from maven days. I don't have a
*conceptual* problem with Maven (except that I wish it were more geared
towards storing versioned dependencies locally forever), it's the execution
that's extremely poor. And extending its capabilities is a nightmare.
Something better could and should exist.
On Sun, Jan 15, 2017 at 9:34 PM, Jordan Zimmerman <
jordan@jordanzimmerman.com> wrote:
> I love Maven :D
>
> https://rule1.quora.com/Use-Maven-Not-Gradle
>
> -JZ
>
>
> On Jan 15, 2017, at 12:36 PM, Scott Blum <dr...@gmail.com> wrote:
>
> I glanced at the maven shade one, seemed okay. Maven is such a shit ball
> though that the rule of thumb is that of the output is right, it's right.
> Lol
>
> On Jan 15, 2017 8:30 AM, "Jordan Zimmerman" <jo...@jordanzimmerman.com>
> wrote:
>
> Thanks Cameron
>
> On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mc...@gmail.com>
>
> wrote:
>
>
> I've been looking at the CURATOR-99 PR, but it's going to take a while,
> it's quite a large PR.
>
> The Maven shading one, I'm not going to be much use reviewing as my
> knowledge of Maven is very limited.
> cheers
>
> On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
>
> Hello Folks,
>
> The following Pull Requests could really use review. If you have a
>
> moment
>
> it would be appreciated:
>
>
> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
> curator/pull/190
> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
> curator/pull/189
>
>
> -Jordan
>
>
>
>
>
Re: Pull Requests needing review
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
I love Maven :D
https://rule1.quora.com/Use-Maven-Not-Gradle <https://rule1.quora.com/Use-Maven-Not-Gradle>
-JZ
> On Jan 15, 2017, at 12:36 PM, Scott Blum <dr...@gmail.com> wrote:
>
> I glanced at the maven shade one, seemed okay. Maven is such a shit ball
> though that the rule of thumb is that of the output is right, it's right.
> Lol
>
> On Jan 15, 2017 8:30 AM, "Jordan Zimmerman" <jo...@jordanzimmerman.com>
> wrote:
>
>> Thanks Cameron
>>
>>> On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mc...@gmail.com>
>> wrote:
>>>
>>> I've been looking at the CURATOR-99 PR, but it's going to take a while,
>>> it's quite a large PR.
>>>
>>> The Maven shading one, I'm not going to be much use reviewing as my
>>> knowledge of Maven is very limited.
>>> cheers
>>>
>>> On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
>>> jordan@jordanzimmerman.com> wrote:
>>>
>>>> Hello Folks,
>>>>
>>>> The following Pull Requests could really use review. If you have a
>> moment
>>>> it would be appreciated:
>>>>
>>>>
>>>> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
>>>> curator/pull/190
>>>> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
>>>> curator/pull/189
>>>>
>>>>
>>>> -Jordan
>>>>
>>
>>
Re: Pull Requests needing review
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
I love Maven :D
https://rule1.quora.com/Use-Maven-Not-Gradle <https://rule1.quora.com/Use-Maven-Not-Gradle>
-JZ
> On Jan 15, 2017, at 12:36 PM, Scott Blum <dr...@gmail.com> wrote:
>
> I glanced at the maven shade one, seemed okay. Maven is such a shit ball
> though that the rule of thumb is that of the output is right, it's right.
> Lol
>
> On Jan 15, 2017 8:30 AM, "Jordan Zimmerman" <jo...@jordanzimmerman.com>
> wrote:
>
>> Thanks Cameron
>>
>>> On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mc...@gmail.com>
>> wrote:
>>>
>>> I've been looking at the CURATOR-99 PR, but it's going to take a while,
>>> it's quite a large PR.
>>>
>>> The Maven shading one, I'm not going to be much use reviewing as my
>>> knowledge of Maven is very limited.
>>> cheers
>>>
>>> On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
>>> jordan@jordanzimmerman.com> wrote:
>>>
>>>> Hello Folks,
>>>>
>>>> The following Pull Requests could really use review. If you have a
>> moment
>>>> it would be appreciated:
>>>>
>>>>
>>>> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
>>>> curator/pull/190
>>>> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
>>>> curator/pull/189
>>>>
>>>>
>>>> -Jordan
>>>>
>>
>>
Re: Pull Requests needing review
Posted by Scott Blum <dr...@gmail.com>.
I glanced at the maven shade one, seemed okay. Maven is such a shit ball
though that the rule of thumb is that of the output is right, it's right.
Lol
On Jan 15, 2017 8:30 AM, "Jordan Zimmerman" <jo...@jordanzimmerman.com>
wrote:
> Thanks Cameron
>
> > On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mc...@gmail.com>
> wrote:
> >
> > I've been looking at the CURATOR-99 PR, but it's going to take a while,
> > it's quite a large PR.
> >
> > The Maven shading one, I'm not going to be much use reviewing as my
> > knowledge of Maven is very limited.
> > cheers
> >
> > On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
> > jordan@jordanzimmerman.com> wrote:
> >
> >> Hello Folks,
> >>
> >> The following Pull Requests could really use review. If you have a
> moment
> >> it would be appreciated:
> >>
> >>
> >> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
> >> curator/pull/190
> >> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
> >> curator/pull/189
> >>
> >>
> >> -Jordan
> >>
>
>
Re: Pull Requests needing review
Posted by Scott Blum <dr...@gmail.com>.
I glanced at the maven shade one, seemed okay. Maven is such a shit ball
though that the rule of thumb is that of the output is right, it's right.
Lol
On Jan 15, 2017 8:30 AM, "Jordan Zimmerman" <jo...@jordanzimmerman.com>
wrote:
> Thanks Cameron
>
> > On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mc...@gmail.com>
> wrote:
> >
> > I've been looking at the CURATOR-99 PR, but it's going to take a while,
> > it's quite a large PR.
> >
> > The Maven shading one, I'm not going to be much use reviewing as my
> > knowledge of Maven is very limited.
> > cheers
> >
> > On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
> > jordan@jordanzimmerman.com> wrote:
> >
> >> Hello Folks,
> >>
> >> The following Pull Requests could really use review. If you have a
> moment
> >> it would be appreciated:
> >>
> >>
> >> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
> >> curator/pull/190
> >> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
> >> curator/pull/189
> >>
> >>
> >> -Jordan
> >>
>
>
Re: Pull Requests needing review
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
Thanks Cameron
> On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mc...@gmail.com> wrote:
>
> I've been looking at the CURATOR-99 PR, but it's going to take a while,
> it's quite a large PR.
>
> The Maven shading one, I'm not going to be much use reviewing as my
> knowledge of Maven is very limited.
> cheers
>
> On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
>
>> Hello Folks,
>>
>> The following Pull Requests could really use review. If you have a moment
>> it would be appreciated:
>>
>>
>> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
>> curator/pull/190
>> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
>> curator/pull/189
>>
>>
>> -Jordan
>>
Re: Pull Requests needing review
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
Thanks Cameron
> On Jan 13, 2017, at 11:33 PM, Cameron McKenzie <mc...@gmail.com> wrote:
>
> I've been looking at the CURATOR-99 PR, but it's going to take a while,
> it's quite a large PR.
>
> The Maven shading one, I'm not going to be much use reviewing as my
> knowledge of Maven is very limited.
> cheers
>
> On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
> jordan@jordanzimmerman.com> wrote:
>
>> Hello Folks,
>>
>> The following Pull Requests could really use review. If you have a moment
>> it would be appreciated:
>>
>>
>> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
>> curator/pull/190
>> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
>> curator/pull/189
>>
>>
>> -Jordan
>>
Re: Pull Requests needing review
Posted by Cameron McKenzie <mc...@gmail.com>.
I've been looking at the CURATOR-99 PR, but it's going to take a while,
it's quite a large PR.
The Maven shading one, I'm not going to be much use reviewing as my
knowledge of Maven is very limited.
cheers
On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
jordan@jordanzimmerman.com> wrote:
> Hello Folks,
>
> The following Pull Requests could really use review. If you have a moment
> it would be appreciated:
>
>
> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
> curator/pull/190
> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
> curator/pull/189
>
>
> -Jordan
>
Re: Pull Requests needing review
Posted by Cameron McKenzie <mc...@gmail.com>.
I've been looking at the CURATOR-99 PR, but it's going to take a while,
it's quite a large PR.
The Maven shading one, I'm not going to be much use reviewing as my
knowledge of Maven is very limited.
cheers
On Sat, Jan 14, 2017 at 2:12 AM, Jordan Zimmerman <
jordan@jordanzimmerman.com> wrote:
> Hello Folks,
>
> The following Pull Requests could really use review. If you have a moment
> it would be appreciated:
>
>
> - [CURATOR-200] Shade Guava into Curator - https://github.com/apache/
> curator/pull/190
> - [CURATOR-99] Java 8 DSL for Curator - https://github.com/apache/
> curator/pull/189
>
>
> -Jordan
>