[GitHub] [incubator-echarts] 100pah commented on a change in pull request #11729: Fix emphasis line style options do not work on Sankey charts #9942

[GitBox <gi...@apache.org>]

100pah commented on a change in pull request #11729: Fix emphasis line style options do not work on Sankey charts #9942
URL: https://github.com/apache/incubator-echarts/pull/11729#discussion_r352034716
 
 

 ##########
 File path: src/chart/sankey/SankeyView.js
 ##########
 @@ -274,8 +286,19 @@ export default echarts.extendChartView({
                 el.cursor = 'move';
             }
 
+            el.highlight = function () {
+                this.trigger('emphasis');
+            };
+
+            el.downplay = function () {
+                this.trigger('normal');
+            };
 
 Review comment:
   Should better not mount method dynamically to an instance.
   It's fine just call `el.trigger`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org