You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/01/26 10:02:48 UTC

[GitHub] [kafka] tombentley opened a new pull request #9972: KAFKA-8779: Reintroduce flaky tests

tombentley opened a new pull request #9972:
URL: https://github.com/apache/kafka/pull/9972


   This draft PR to to try to see how the flaky tests fail.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] tombentley commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9972:
URL: https://github.com/apache/kafka/pull/9972#issuecomment-772458645


   I've now run these tests 4 or 5 times in CI and not seen any failures in the previously flaky tests where previously I did, so I'm hopeful that these changes to indeed fix the issue.
   
   @chia7712 or @mimaison perhaps one of you could review this change?
   
   cc @stanislavkozlovski who wrote the tests originally.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] chia7712 commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9972:
URL: https://github.com/apache/kafka/pull/9972#issuecomment-772516599


   > The cause of the flakiness appears to have been lack of test isolation between those tests and other tests which manipulate log levels (which are effectively global to the JVM). In general there are quite a few tests which manipulate log4j and/or make assertions on log4j global state, so introduce some of helpers to try to get test isolation across the whole of the broker code.
   
   IIRC, gradle forks `n` JVMs to run `n` tests parallel and tests in same JVM are executed sequentially. Hence, could we reset log4j state (maybe in `@AfterEach`) instead of global locking? Please correct me if I misunderstand the root cause. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] ijuma commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9972:
URL: https://github.com/apache/kafka/pull/9972#issuecomment-1033748707


   @chia7712 Does this look good to you?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] tombentley commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9972:
URL: https://github.com/apache/kafka/pull/9972#issuecomment-773183761


   Rebased to trigger CI again.
   
   @chia7712 please could to take another look when you have the chance?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] tombentley commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9972:
URL: https://github.com/apache/kafka/pull/9972#issuecomment-784929401


   Rebased to trigger CI again.
   
   @chia7712 would you be able to take another look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] tombentley commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9972:
URL: https://github.com/apache/kafka/pull/9972#issuecomment-773183761


   Rebased to trigger CI again.
   
   @chia7712 please could to take another look when you have the chance?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] tombentley commented on pull request #9972: KAFKA-8779: Reintroduce flaky tests

Posted by GitBox <gi...@apache.org>.
tombentley commented on pull request #9972:
URL: https://github.com/apache/kafka/pull/9972#issuecomment-772542951


   Thanks @chia7712 that's an excellent point! Maybe it's worth inlining `withLogReset` since it offers little value now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org