You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/02/01 00:18:55 UTC
Review Request: SQOOP-654 PostgreSQL direct connector is ignoring
--null(-input)string and --null(-input)-non-string arguments
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9204/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
This patches fixes the NULL handling in PostgreSQL direct connector.
This addresses bug SQOOP-654.
https://issues.apache.org/jira/browse/SQOOP-654
Diffs
-----
src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java dba732c963416202934cb95b86eac274a3e1a2dd
src/java/org/apache/sqoop/util/SubstitutionUtils.java PRE-CREATION
src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java 512b1d5566e6aad221e9b8b8c15be1e6037ad4f2
src/test/com/cloudera/sqoop/util/TestSubstitutionUtils.java PRE-CREATION
Diff: https://reviews.apache.org/r/9204/diff/
Testing
-------
Added new test case that covers this eventuality.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-654 PostgreSQL direct connector is ignoring
--null(-input)string and --null(-input)-non-string arguments
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9204/#review16211
-----------------------------------------------------------
Ship it!
Ship It!
- Cheolsoo Park
On Jan. 31, 2013, 11:18 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9204/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2013, 11:18 p.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> This patches fixes the NULL handling in PostgreSQL direct connector.
>
>
> This addresses bug SQOOP-654.
> https://issues.apache.org/jira/browse/SQOOP-654
>
>
> Diffs
> -----
>
> src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java dba732c963416202934cb95b86eac274a3e1a2dd
> src/java/org/apache/sqoop/util/SubstitutionUtils.java PRE-CREATION
> src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java 512b1d5566e6aad221e9b8b8c15be1e6037ad4f2
> src/test/com/cloudera/sqoop/util/TestSubstitutionUtils.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/9204/diff/
>
>
> Testing
> -------
>
> Added new test case that covers this eventuality.
>
>
> Thanks,
>
> Jarek Cecho
>
>