You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "bsovran (via GitHub)" <gi...@apache.org> on 2026/06/18 14:45:36 UTC

[PR] feat(charts): add extensible extra metadata column to slices [superset]

bsovran opened a new pull request, #41200:
URL: https://github.com/apache/superset/pull/41200

   ### SUMMARY
   
   Adds a nullable `extra` column to the `slices` table (and the `Slice` model) to store open-ended, structured chart metadata, mirroring the long-standing dataset `extra` pattern.
   
   Charts currently have no extensible metadata field. `description` is unsuitable because it is user-facing prose rendered as markdown and shown as a tooltip in the Charts list. Datasets already solve this with an `extra` JSON-bearing column (`SqlaTable.extra`), and columns/metrics have their own `extra` as well. This change brings the same proven, low-risk pattern to charts.
   
   Design decisions:
   - Column name `extra`, consistent with `tables.extra` and column/metric `extra`.
   - Type `MediumText` (`superset.utils.core.MediumText`), which resolves to `TEXT` on Postgres/SQLite and `MEDIUMTEXT` on MySQL. This matches the existing JSON-bearing chart fields `params` and `query_context`, avoids MySQL's 64KB `TEXT` limit, and stores identical bytes across backends (unlike a native JSON column, which MySQL normalizes/reorders).
   - Nullable, no server default. JSON is stored as a string and parsed at the application layer, exactly as `SqlaTable.extra_dict` does today.
   - Added `extra` to `Slice.export_fields` so it round-trips through import/export.
   
   This PR intentionally scopes to the model + migration foundation. Exposing `extra` through the chart REST API (`ChartPostSchema`/`ChartPutSchema`/response schema) and any UI can follow in a separate PR.
   
   Associated SIP: https://github.com/apache/superset/issues/41171
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A - backend schema change with no UI surface in this PR.
   
   ### TESTING INSTRUCTIONS
   
   1. Run `superset db upgrade` and confirm the `extra` column is added to `slices` (nullable).
   2. Run `superset db downgrade` and confirm the column is cleanly removed.
   3. Confirm `superset db heads` reports a single head.
   4. Set/read `Slice.extra` (e.g. via shell) and confirm round-trip through chart export/import.
   
   The migration uses the idempotent `add_columns`/`drop_columns` helpers from `superset/migrations/shared/utils.py`, following the exact shape of the existing `94e7a3499973` (add `folders` to datasets) migration. Upgrade/downgrade of the additive column was exercised against a local metadata DB.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: https://github.com/apache/superset/issues/41171
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [x] Migration is atomic, supports rollback & is backwards-compatible
     - [x] Confirm DB migration upgrade and downgrade tested
     - [x] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   Runtime/downtime: adding a nullable column to `slices` is a metadata-only DDL change on Postgres (no table rewrite, no default backfill) and completes near-instantly; no downtime expected. MySQL 8 performs this as an INSTANT add for a nullable column.
   
   Made with [Cursor](https://cursor.com)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(charts): add extensible extra metadata column to slices [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #41200:
URL: https://github.com/apache/superset/pull/41200#issuecomment-4743148109

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 897c634dcf6d9d41a14f250cdf1c161867558fb7 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a34049090bb6000088ba33a |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-41200--superset-docs-preview.netlify.app](https://deploy-preview-41200--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQxMjAwLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.QKyDdJfBOdikjmJx7kRsOpfR6tj3D7OLRqKejsNVHBg)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpLCoAgFEbhvdxxkmCItoOW8fsIB76QGxTR3vOMzuB7qY9WOtNOtJAbqD7NPyN49QmDRbx5QJTICGAI3_JV6rQh9tyeI0ytoTa5WWmlc1rOjHFQCvT9) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-41200--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(charts): add extensible extra metadata column to slices [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41200:
URL: https://github.com/apache/superset/pull/41200#issuecomment-4743131600

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(charts): add extensible extra metadata column to slices [superset]

Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #41200:
URL: https://github.com/apache/superset/pull/41200#discussion_r3436751279


##########
superset/models/slice.py:
##########
@@ -82,6 +82,7 @@ class Slice(  # pylint: disable=too-many-public-methods
     viz_type = Column(String(250))
     params = Column(utils.MediumText())
     query_context = Column(utils.MediumText())
+    extra = Column(utils.MediumText())

Review Comment:
   **Suggestion:** The new chart metadata field is persisted on the model but not copied when charts are cloned, so dashboard duplication will silently drop `extra` metadata on the duplicated charts. Update the chart cloning path to include this new field so cloned charts preserve the same metadata as the source chart. [incomplete implementation]
   
   <details>
   <summary><b>Severity Level:</b> Major ⚠️</summary>
   
   ```mdx
   - ⚠️ Dashboard copy with duplicate charts drops chart extra metadata.
   - ⚠️ Cloned charts diverge from originals in stored configuration.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. In a running Superset instance with this PR applied, pick an existing dashboard with
   charts and ensure at least one chart has `Slice.extra` set (e.g. via a shell or test
   fixture): `original_slc.extra = '{"foo": "bar"}'` for a `Slice` instance attached to a
   dashboard. The `Slice` model (including the new `extra` column) is defined in
   `superset/models/slice.py:17-27` as seen in the class definition.
   
   2. Trigger a dashboard copy operation with chart duplication enabled. In production this
   is done via the dashboard copy API which uses `CopyDashboardCommand`
   (`superset/commands/dashboard/copy.py:6-15`) and `DashboardDAO.copy_dashboard`. In tests
   the same path is exercised directly in
   `superset/tests/integration_tests/dashboards/dao_tests.py:27-42`, where
   `DashboardDAO.copy_dashboard(original_dash, dash_data)` is called with
   `dash_data["duplicate_slices"] = True`.
   
   3. During the copy operation, `DashboardDAO.copy_dashboard` in
   `superset/daos/dashboard.py:368-46` iterates over `original_dash.slices` and, when
   `duplicate_slices` is true, calls `new_slice = slc.clone()` at line 386 for each chart,
   then adds each `new_slice` to the session and associates it with the new dashboard.
   
   4. The `Slice.clone` method in `superset/models/slice.py:151-42` constructs a new `Slice`
   with only `slice_name`, `datasource_id`, `datasource_type`, `datasource_name`, `viz_type`,
   `params`, `description`, and `cache_timeout`, and does not copy the `extra` field. As a
   result, each cloned chart's `extra` column remains NULL/empty even though the source
   chart's `extra` contained metadata, so the duplicated dashboard's charts silently lose
   their `extra` metadata.
   ```
   </details>
   
   [![Fix in Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=984bb79acd46453aa6906d294073207c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [![Fix in VSCode Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=984bb79acd46453aa6906d294073207c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/models/slice.py
   **Line:** 85:85
   **Comment:**
   	*Incomplete Implementation: The new chart metadata field is persisted on the model but not copied when charts are cloned, so dashboard duplication will silently drop `extra` metadata on the duplicated charts. Update the chart cloning path to include this new field so cloned charts preserve the same metadata as the source chart.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41200&comment_hash=ea1edd6092344ea144f54567426c5d3b0ff7195f65e8d78842da24a2b3c4923d&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41200&comment_hash=ea1edd6092344ea144f54567426c5d3b0ff7195f65e8d78842da24a2b3c4923d&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(charts): add extensible extra metadata column to slices [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41200:
URL: https://github.com/apache/superset/pull/41200#issuecomment-4744892297

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(charts): add extensible extra metadata column to slices [superset]

Posted by "durgaprasadml (via GitHub)" <gi...@apache.org>.
durgaprasadml commented on PR #41200:
URL: https://github.com/apache/superset/pull/41200#issuecomment-4756867344

   Thanks for the contribution. I reviewed the migration, model, export/import, and clone path changes.
   
   One question: datasets expose an extra_dict convenience property for parsed access to the JSON stored in extra. Do we anticipate needing a similar helper on Slice, or is the expectation that consumers will parse the JSON directly until API/UI support is added in a follow-up PR?
   
   Otherwise, the implementation looks straightforward and consistent with existing extra patterns.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(charts): add extensible extra metadata column to slices [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #41200:
URL: https://github.com/apache/superset/pull/41200#discussion_r3463023184


##########
superset/charts/schemas.py:
##########
@@ -1735,6 +1735,7 @@ class ImportV1ChartSchema(Schema):
     viz_type = fields.String(required=True)
     params = fields.Dict()
     query_context = fields.String(allow_none=True, validate=utils.validate_json)
+    extra = fields.String(allow_none=True, validate=utils.validate_json)

Review Comment:
   This adds `extra` to the import schema, but the REST API schemas don't declare it: `ChartPostSchema` (line 225), `ChartPutSchema` (line 287), and `ChartEntityResponseSchema` (line 204). As written, `extra` gets silently dropped on `POST`/`PUT /api/v1/chart/` and is absent from the `GET` response, so the column is only reachable through import/export.
   
   Is REST read/write in scope for this PR? If so, add `extra` to those three schemas the same way `query_context` is wired (`fields.String` + `utils.validate_json`). If this is intentionally import-only groundwork for the SIP, can you note that in the PR description so the REST follow-up doesn't get lost?



##########
superset/models/slice.py:
##########
@@ -82,6 +82,7 @@ class Slice(  # pylint: disable=too-many-public-methods
     viz_type = Column(String(250))
     params = Column(utils.MediumText())
     query_context = Column(utils.MediumText())
+    extra = Column(utils.MediumText())

Review Comment:
   Why `MediumText()` here instead of `Text`? `SqlaTable.extra`, the precedent this is following, is `Column(Text)`. I can see the argument for matching `params`/`query_context` on this model instead, just want to confirm the divergence from the sibling `extra` field is deliberate.



##########
tests/integration_tests/charts/commands_tests.py:
##########
@@ -104,6 +104,7 @@ def test_export_chart_command(self, mock_g):
             "uuid": str(example_chart.uuid),
             "version": "1.0.0",
             "query_context": None,
+            "extra": None,

Review Comment:
   Both additions here (and the key-order one at line 156) only assert that the `extra` key appears in the export. Nothing exercises a non-null value surviving a round-trip, or `clone()` carrying `extra` across. Could you add a positive round-trip test (set `extra='{"foo":"bar"}'`, export, re-import, assert it's preserved) and a `clone()` assertion (`assert slice.clone().extra == slice.extra`)? The second one would lock in the behavior the static-analysis bot flagged as missing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(charts): add extensible extra metadata column to slices [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #41200:
URL: https://github.com/apache/superset/pull/41200#issuecomment-4743167556

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/41200?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 54.85%. Comparing base ([`c218dc4`](https://app.codecov.io/gh/apache/superset/commit/c218dc418ba717a243e6e27a84e6ddcc1cd01577?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`897c634`](https://app.codecov.io/gh/apache/superset/commit/897c634dcf6d9d41a14f250cdf1c161867558fb7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #41200      +/-   ##
   ==========================================
   - Coverage   64.33%   54.85%   -9.48%     
   ==========================================
     Files        2651     2651              
     Lines      144766   144767       +1     
     Branches    33401    33401              
   ==========================================
   - Hits        93131    79415   -13716     
   - Misses      49965    64953   +14988     
   + Partials     1670      399    -1271     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/41200/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/41200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.32% <100.00%> (+<0.01%)` | :arrow_up: |
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/41200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/41200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/41200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/41200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.32% <100.00%> (-20.25%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/41200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/41200/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/41200?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(charts): add extensible extra metadata column to slices [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #41200:
URL: https://github.com/apache/superset/pull/41200#issuecomment-4743189486

   <!-- Bito Reply -->
   The flagged issue is correct. The `Slice.clone` method (which is not visible in the provided diff but is referenced in the reproduction steps) needs to be updated to include the `extra` field in the dictionary of attributes copied from the source slice to the new slice. 
   
   To resolve this, locate the `clone` method in `superset/models/slice.py` and add `extra` to the attributes being copied:
   
   ```python
   # In superset/models/slice.py, inside the clone() method:
   new_slice = Slice(
       slice_name=self.slice_name,
       # ... existing fields ...
       extra=self.extra,
       # ...
   )
   ```
   
   There are no other comments on this PR to address.
   
   **superset/models/slice.py**
   ```
   new_slice = Slice(
       slice_name=self.slice_name,
       # ... existing fields ...
       extra=self.extra,
       # ...
   )
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] feat(charts): add extensible extra metadata column to slices [superset]

Posted by "bsovran (via GitHub)" <gi...@apache.org>.
bsovran closed pull request #41200: feat(charts): add extensible extra metadata column to slices
URL: https://github.com/apache/superset/pull/41200


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org