You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ian Duffy <ia...@ianduffy.ie> on 2013/06/17 15:18:45 UTC
Review Request: Fix CLOUDSTACK-2168
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/
-----------------------------------------------------------
Review request for cloudstack and Sebastien Goasguen.
Description
-------
CLOUDSTACK-2168 detailed a bug that caused the ldap configuration to not appear.
This bug occurred due to the UI expecting a "list" of ldap configurations back from the API.
I have modified the API command to return a "list" like format, but since cloudstack only currently supports authentication against one ldap server it will only return 1 configuration.
Whoever takes up CLOUDSTACK-430 https://issues.apache.org/jira/browse/CLOUDSTACK-430 - Add support for multiple ldap servers will have to expand on this output.
This addresses bug CLOUDSTACK-2168.
Diffs
-----
api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 2726f84
Diff: https://reviews.apache.org/r/11907/diff/
Testing
-------
Build the code with the changes, confirmed the API still returned the expected results.
Confirmed that the UI showed the configuration.
Thanks,
Ian Duffy
Re: Review Request: Fix CLOUDSTACK-2168
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/#review22153
-----------------------------------------------------------
Commit d3d6350219c9f02ce5d604a81a0c3c12ff700672 in branch refs/heads/master from Abhinandan Prateek
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d3d6350 ]
CLOUDSTACK-2168: removed unused commit
- ASF Subversion and Git Services
On June 18, 2013, 8:38 a.m., Ian Duffy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11907/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 8:38 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.
>
>
> Description
> -------
>
> CLOUDSTACK-2168 detailed a bug that caused the ldap configuration to not appear.
>
> This bug occurred due to the UI expecting a "list" of ldap configurations back from the API.
>
> I have modified the API command to return a "list" like format, but since cloudstack only currently supports authentication against one ldap server it will only return 1 configuration.
>
> Whoever takes up CLOUDSTACK-430 https://issues.apache.org/jira/browse/CLOUDSTACK-430 - Add support for multiple ldap servers will have to expand on this output.
>
>
> This addresses bug CLOUDSTACK-2168.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 2726f84
>
> Diff: https://reviews.apache.org/r/11907/diff/
>
>
> Testing
> -------
>
> Build the code with the changes, confirmed the API still returned the expected results.
> Confirmed that the UI showed the configuration.
>
>
> Thanks,
>
> Ian Duffy
>
>
Re: Review Request: Fix CLOUDSTACK-2168
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/#review22154
-----------------------------------------------------------
Commit 576884ec10b4a46b243b8138926c0fc650bcdaba in branch refs/heads/master from Ian Duffy
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=576884e ]
Add fix for CLOUDSTACK-2168. Changed listAll output to conform to the same output as listconfiguration
Signed-off-by: Abhinandan Prateek <ap...@apache.org>
- ASF Subversion and Git Services
On June 18, 2013, 8:38 a.m., Ian Duffy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11907/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 8:38 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.
>
>
> Description
> -------
>
> CLOUDSTACK-2168 detailed a bug that caused the ldap configuration to not appear.
>
> This bug occurred due to the UI expecting a "list" of ldap configurations back from the API.
>
> I have modified the API command to return a "list" like format, but since cloudstack only currently supports authentication against one ldap server it will only return 1 configuration.
>
> Whoever takes up CLOUDSTACK-430 https://issues.apache.org/jira/browse/CLOUDSTACK-430 - Add support for multiple ldap servers will have to expand on this output.
>
>
> This addresses bug CLOUDSTACK-2168.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 2726f84
>
> Diff: https://reviews.apache.org/r/11907/diff/
>
>
> Testing
> -------
>
> Build the code with the changes, confirmed the API still returned the expected results.
> Confirmed that the UI showed the configuration.
>
>
> Thanks,
>
> Ian Duffy
>
>
Re: Review Request: Fix CLOUDSTACK-2168
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/#review22152
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On June 18, 2013, 8:38 a.m., Ian Duffy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11907/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 8:38 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.
>
>
> Description
> -------
>
> CLOUDSTACK-2168 detailed a bug that caused the ldap configuration to not appear.
>
> This bug occurred due to the UI expecting a "list" of ldap configurations back from the API.
>
> I have modified the API command to return a "list" like format, but since cloudstack only currently supports authentication against one ldap server it will only return 1 configuration.
>
> Whoever takes up CLOUDSTACK-430 https://issues.apache.org/jira/browse/CLOUDSTACK-430 - Add support for multiple ldap servers will have to expand on this output.
>
>
> This addresses bug CLOUDSTACK-2168.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 2726f84
>
> Diff: https://reviews.apache.org/r/11907/diff/
>
>
> Testing
> -------
>
> Build the code with the changes, confirmed the API still returned the expected results.
> Confirmed that the UI showed the configuration.
>
>
> Thanks,
>
> Ian Duffy
>
>
Re: Review Request: Fix CLOUDSTACK-2168
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/#review22106
-----------------------------------------------------------
api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java
<https://reviews.apache.org/r/11907/#comment45498>
Minor: Hyp..CapabilitiesResponse import is not required here.
- Abhinandan Prateek
On June 18, 2013, 8:38 a.m., Ian Duffy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11907/
> -----------------------------------------------------------
>
> (Updated June 18, 2013, 8:38 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.
>
>
> Description
> -------
>
> CLOUDSTACK-2168 detailed a bug that caused the ldap configuration to not appear.
>
> This bug occurred due to the UI expecting a "list" of ldap configurations back from the API.
>
> I have modified the API command to return a "list" like format, but since cloudstack only currently supports authentication against one ldap server it will only return 1 configuration.
>
> Whoever takes up CLOUDSTACK-430 https://issues.apache.org/jira/browse/CLOUDSTACK-430 - Add support for multiple ldap servers will have to expand on this output.
>
>
> This addresses bug CLOUDSTACK-2168.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 2726f84
>
> Diff: https://reviews.apache.org/r/11907/diff/
>
>
> Testing
> -------
>
> Build the code with the changes, confirmed the API still returned the expected results.
> Confirmed that the UI showed the configuration.
>
>
> Thanks,
>
> Ian Duffy
>
>
Re: Review Request: Fix CLOUDSTACK-2168
Posted by Ian Duffy <ia...@ianduffy.ie>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/
-----------------------------------------------------------
(Updated June 18, 2013, 8:38 a.m.)
Review request for cloudstack, Abhinandan Prateek and Sebastien Goasguen.
Description
-------
CLOUDSTACK-2168 detailed a bug that caused the ldap configuration to not appear.
This bug occurred due to the UI expecting a "list" of ldap configurations back from the API.
I have modified the API command to return a "list" like format, but since cloudstack only currently supports authentication against one ldap server it will only return 1 configuration.
Whoever takes up CLOUDSTACK-430 https://issues.apache.org/jira/browse/CLOUDSTACK-430 - Add support for multiple ldap servers will have to expand on this output.
This addresses bug CLOUDSTACK-2168.
Diffs
-----
api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 2726f84
Diff: https://reviews.apache.org/r/11907/diff/
Testing
-------
Build the code with the changes, confirmed the API still returned the expected results.
Confirmed that the UI showed the configuration.
Thanks,
Ian Duffy
Re: Review Request: Fix CLOUDSTACK-2168
Posted by Ian Duffy <ia...@ianduffy.ie>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11907/
-----------------------------------------------------------
(Updated June 17, 2013, 2 p.m.)
Review request for cloudstack and Sebastien Goasguen.
Description
-------
CLOUDSTACK-2168 detailed a bug that caused the ldap configuration to not appear.
This bug occurred due to the UI expecting a "list" of ldap configurations back from the API.
I have modified the API command to return a "list" like format, but since cloudstack only currently supports authentication against one ldap server it will only return 1 configuration.
Whoever takes up CLOUDSTACK-430 https://issues.apache.org/jira/browse/CLOUDSTACK-430 - Add support for multiple ldap servers will have to expand on this output.
This addresses bug CLOUDSTACK-2168.
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/admin/ldap/LDAPConfigCmd.java 2726f84
Diff: https://reviews.apache.org/r/11907/diff/
Testing
-------
Build the code with the changes, confirmed the API still returned the expected results.
Confirmed that the UI showed the configuration.
Thanks,
Ian Duffy