You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sarvekshayr (via GitHub)" <gi...@apache.org> on 2025/01/10 06:50:20 UTC
[PR] HDDS-12054. Move ozone debug prefix to ozone debug om prefix [ozone]
sarvekshayr opened a new pull request, #7674:
URL: https://github.com/apache/ozone/pull/7674
## What changes were proposed in this pull request?
The prefix subcommand only works on OM using the FSO namespace so it should be under the om subcommand.
## What is the link to the Apache JIRA
[HDDS-12054](https://issues.apache.org/jira/browse/HDDS-12054)
## How was this patch tested?
Tested the patch on a docker cluster and through `TestOzoneFileSystemPrefixParser.java`
```
bash-5.1$ ozone debug om
Missing required subcommand
Usage: ozone debug om [COMMAND]
Runs OM related subcommands.
Commands:
prefix Parse prefix contents
```
```
bash-5.1$ ozone debug om prefix
Missing required options: '--db=<dbPath>', '--path=<filePath>', '--bucket=<bucket>', '--volume=<volume>'
Usage: ozone debug om prefix --bucket=<bucket> --db=<dbPath> --path=<filePath>
--volume=<volume>
Parse prefix contents
--bucket=<bucket> bucket name
--db=<dbPath> Database File Path
--path=<filePath> prefixFile Path
--volume=<volume> volume name
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12054. Move ozone debug prefix to ozone debug om prefix [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7674:
URL: https://github.com/apache/ozone/pull/7674#issuecomment-2583237066
Thanks @sarvekshayr for the patch, @Tejaskriya for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12054. Move ozone debug prefix to ozone debug om prefix [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7674:
URL: https://github.com/apache/ozone/pull/7674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12054. Move ozone debug prefix to ozone debug om prefix [ozone]
Posted by "Tejaskriya (via GitHub)" <gi...@apache.org>.
Tejaskriya commented on code in PR #7674:
URL: https://github.com/apache/ozone/pull/7674#discussion_r1910005536
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/om/OMDebug.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.debug.om;
+
+import org.apache.hadoop.hdds.cli.DebugSubcommand;
+import org.kohsuke.MetaInfServices;
+import picocli.CommandLine;
+
+/**
+ * OM debug related commands.
+ */
+@CommandLine.Command(
+ name = "om",
+ description = "Runs OM related subcommands.",
Review Comment:
nit:
```suggestion
description = "Debug commands related to OM.",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org