[Axis2] Inconsistencies in getting engaged modules

[Saminda Abeyruwan <sa...@gmail.com>]

Hi Devs,

We've came across the following inconsistencies when calling
getEngagedModules() method, in
1. AxisOperation
2. AxisService
3. AxisServiceGroup

AxisOperation has,
public Collection getEngagedModules() {...} --> This will give an instance
of ArrayList which has AxisModule  objects.

AxisService has,
public Collection getEngagedModules() {...} --> This will give an instance
of ArrayList which has String objects.

String objects are the names of engaged modules.

AxisServiceGroup has,
public ArrayList getEngagedModules() {...} --> This will give an instance of
ArrayList which has String objects.

String objects are the names of engaged modules.

This will lead to difficulties when working with them.

IMHO  getEngagedModules() should be a method an abstract in AxisDescription;


public Collection getEngagedModules()

or

public List getEngagedModules(),

and should return either AxisModule or Name of the module as String. IMHO
AxisModule would be preferable. Thus, others that extend from AxisDecription
will be benefited too.

Please be kind enough to  express your thoughts on  prior.

Thank you

Saminda





-- 
Saminda Abeyruwan

Software Engineer
WSO2 Inc. - www.wso2.org

Re: [Axis2] Inconsistencies in getting engaged modules

[Davanum Srinivas <da...@gmail.com>]

+1 standardize it. +1 to return List containing AxisModules.

thanks,
dims

On 5/4/07, Saminda Abeyruwan <sa...@gmail.com> wrote:
> Hi Devs,
>
> We've came across the following inconsistencies when calling
> getEngagedModules() method, in
> 1. AxisOperation
> 2. AxisService
> 3. AxisServiceGroup
>
> AxisOperation has,
> public Collection getEngagedModules() {...} --> This will give an instance
> of ArrayList which has AxisModule  objects.
>
> AxisService has,
> public Collection getEngagedModules() {...} --> This will give an instance
> of ArrayList which has String objects.
>
>                  String objects are the names of engaged
> modules.
>
> AxisServiceGroup has,
> public ArrayList getEngagedModules() {...} --> This will give an instance of
> ArrayList which has String objects.
>
>                  String objects are the names of engaged
> modules.
>
> This will lead to difficulties when working with them.
>
> IMHO  getEngagedModules() should be a method an abstract in AxisDescription;
>
> public Collection getEngagedModules()
>
> or
>
> public List getEngagedModules(),
>
> and should return either AxisModule or Name of the module as String. IMHO
> AxisModule would be preferable. Thus, others that extend from AxisDecription
> will be benefited too.
>
> Please be kind enough to  express your thoughts on  prior.
>
> Thank you
>
> Saminda
>
>
>
>
>
> --
> Saminda Abeyruwan
>
> Software Engineer
> WSO2 Inc. - www.wso2.org


-- 
Davanum Srinivas :: http://davanum.wordpress.com

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org