[GitHub] [incubator-nuttx] patacongo commented on pull request #987: Implement the up_tls_info for the rest of the architectures

[GitBox <gi...@apache.org>]

patacongo commented on pull request #987:
URL: https://github.com/apache/incubator-nuttx/pull/987#issuecomment-624952836


   As you mentioned, the implementation is incomplete for z16 and z80 because you are missing assembly language functions to get the SP in most of those cases.
   
   I do not think this is a problem for those architectures.  The stack pointer is only needed in the ALIGNED TLS case and the ALIGNED TLS case is not appropriate for the z80 and z180 architectures.  z16f and ez80 are possibilities but not likely.  We do needed the unaligned TLS case implemented.  My recommendation for now is to add logic like:
   
       #ifdef CONFIG_TLS_ALIGNED
       #  errno Aligned TLS not supported
       #else
       #  define up_tls_info() tls_get_info()
       #endf
   
   That provided everything that is needed from now and if some crazy person wants to implement aligned TLS on these tiny chips in the future, then they will have to provide the missing logic.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org