You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Egor Pasko (JIRA)" <ji...@apache.org> on 2006/12/28 12:42:24 UTC
[jira] Commented: (HARMONY-2686) [drlvm][jit][opt] Jitrino doesn't
remove unnesassary conditional jumps after constants compare
[ http://issues.apache.org/jira/browse/HARMONY-2686?page=comments#action_12461179 ]
Egor Pasko commented on HARMONY-2686:
-------------------------------------
with the fix in r490506 SPECjbb2005 crashes on assert (on Jitrino built in debug mode):
Timing Measurement began Thu Dec 28 17:19:29 NOVT 2006 for 0.5 minutes
java: /export/users/evpasko/svn/3/trunk/working_vm/vm/jitrino/src/codegenerator/ia32/Ia32Inst.h:225: Jitrino::Ia32::Opnd* Jitrino::Ia32::Opnd::getMemOpndSubOpnd(Jitrino::Ia32::MemOpndSubOpndKind) const: Assertion `memOpndKind != MemOpndKind_Null' failed.
SIGABRT in VM code.
Stack trace:
1: ?? (??:-1)
2: abort (??:-1)
3: __assert_fail (??:-1)
4: Jitrino::Ia32::Opnd::getMemOpndSubOpnd(Jitrino::Ia32::MemOpndSubOpndKind) const (/export/users/evpasko/svn/3/trunk/working_vm/vm/jitrino/src/codegenerator/ia32/Ia32Inst.h:225)
5: Jitrino::Ia32::Inst::getOpnd(unsigned int) const (/export/users/evpasko/svn/3/trunk/working_vm/vm/jitrino/src/codegenerator/ia32/Ia32Inst.h:616)
6: Jitrino::Ia32::BranchTranslator::runImpl() (/export/users/evpasko/svn/3/trunk/working_vm/vm/jitrino/src/codegenerator/ia32/Ia32BranchTrans.cpp:329)
BranchTranslator is guilty
need to reopen the bug and revert the commit
Nikolay, please check you latest BTR (ha-ha) on Jitrino built in debug mode..
> [drlvm][jit][opt] Jitrino doesn't remove unnesassary conditional jumps after constants compare
> ----------------------------------------------------------------------------------------------
>
> Key: HARMONY-2686
> URL: http://issues.apache.org/jira/browse/HARMONY-2686
> Project: Harmony
> Issue Type: Improvement
> Components: DRLVM
> Reporter: Nikolay Sidelnikov
> Assigned To: Alexey Petrenko
> Attachments: branchTranslator.patch, BranchTranslator_fixed.patch, BranchTranslator_v1.2.patch, BranchTranslator_v1.2.patch, BranchTranslator_v1.4.patch, btr_fix.patch
>
>
> There are number of cases when Jitrino is able to remove a branch. For example:
> 1)
> MOV eax, 1
> CMP eax, 0
> JZ
> 2)
> MOV eax, 1
> JMP L1
> MOV eax, 0
> L1: CMP eax, 0
> JZ
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira