You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2018/05/04 09:02:56 UTC

[GitHub] chickenlj commented on issue #1627: [Dubbo- demo easy to use ] enhance for demo start.

chickenlj commented on issue #1627: [Dubbo- demo easy to use ] enhance for demo start.
URL: https://github.com/apache/incubator-dubbo/pull/1627#issuecomment-386543633
 
 
   About the Quick Part (the 'dubbo-demo’ module in code base), i think we need a  guidance for this part. 
   
   Changes in this PR, compared with the current implementation, use less code by removing the explicit use of Spring. The new way, in my opinion, easy but not transparent enough, users even don’t know the startup of a Spring Context.
   
   Snippet:
   
   - Current:
   ```java
   ClassPathXmlApplicationContext context = new ClassPathXmlApplicationContext(new String[]{"META-INF/spring/dubbo-demo-provider.xml"});
   ```
   
   - PR:
   ```java
   Main.main(args);
   ```
   
   Is it better hide as much details as possible for our Quick Start?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org