[GitHub] [cassandra] bowensong commented on a change in pull request #1249: Cassandra 16956 - remove Windows support

[GitBox <gi...@apache.org>]

bowensong commented on a change in pull request #1249:
URL: https://github.com/apache/cassandra/pull/1249#discussion_r755102186



##########
File path: src/java/org/apache/cassandra/utils/NativeLibrary.java
##########
@@ -143,10 +140,8 @@ private static OSType getOsType()
             return LINUX;
         else if (osName.contains("mac"))
             return MAC;
-        else if (osName.contains("windows"))
-            return WINDOWS;
 
-        logger.warn("the current operating system, {}, is unsupported by cassandra", osName);
+        logger.warn("the current operating system, {}, is unsupported by Cassandra", osName);

Review comment:
       based on the information from https://stackoverflow.com/questions/66736736/what-is-the-os-name-system-property-value-in-java-on-windows-subsystem-for-linux I'm pretty sure the `osName` is going to be `"linux"`. Some other StackOverflow posts also supports that. For example: https://stackoverflow.com/questions/68228844/maven-build-failed-due-to-permission-denied-exception-during-test-phase




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org