You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/30 02:33:01 UTC
[GitHub] [flink] FaxianZhao commented on a change in pull request #8248:
[FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float
behavior is not align
FaxianZhao commented on a change in pull request #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align
URL: https://github.com/apache/flink/pull/8248#discussion_r279599496
##########
File path: flink-connectors/flink-jdbc/src/test/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormatTest.java
##########
@@ -133,6 +133,32 @@ public void testExceptionOnInvalidType() throws IOException {
jdbcOutputFormat.writeRecord(row);
}
+ @Test(expected = RuntimeException.class)
Review comment:
agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services