You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2014/02/24 23:03:19 UTC

[jira] [Resolved] (THRIFT-2305) TFramedTransport empty constructor should probably be private

     [ https://issues.apache.org/jira/browse/THRIFT-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-2305.
--------------------------------

    Resolution: Fixed

Committed.

> TFramedTransport empty constructor should probably be private
> -------------------------------------------------------------
>
>                 Key: THRIFT-2305
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2305
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C# - Library
>            Reporter: Alex Ausch
>            Assignee: Jens Geyer
>            Priority: Trivial
>             Fix For: 0.9.2
>
>         Attachments: TFramedTransport_cs_refactor.patch, THRIFT-2305-misc-Transport_refactorings_v2.patch
>
>
> A TFramedTransport without an inner transport doesn't make sense.
> Therefore, the empty constructor should probably not be public - most likely private (possibly protected?).
> Attaching patch file, including some formatting corrections.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)