You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jm...@apache.org on 2017/06/01 05:58:12 UTC
[1/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !===
where safe
Repository: flex-asjs
Updated Branches:
refs/heads/develop 516e04f89 -> 5e0d33052
use === and !=== where safe
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/02a1232c
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/02a1232c
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/02a1232c
Branch: refs/heads/develop
Commit: 02a1232c7806c6e78f3ee7843eee5a7aafbc7c76
Parents: 516e04f
Author: Justin Mclean <jm...@apache.org>
Authored: Thu Jun 1 12:21:51 2017 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Thu Jun 1 12:21:51 2017 +1000
----------------------------------------------------------------------
.../src/main/flex/org/apache/flex/utils/CSSUtils.as | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/02a1232c/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
index dc264f8..36705ba 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
@@ -70,11 +70,11 @@ package org.apache.flex.utils
public static function toNumber(str:String, reference:Number = 0):Number
{
var c:int = str.indexOf("px");
- if (c != -1)
+ if (c !== -1)
return Number(str.substr(0, c));
c = str.indexOf("%");
- if (c != -1)
+ if (c !== -1)
return Number(str.substr(0, c)) * reference / 100;
return Number(str);
@@ -123,17 +123,17 @@ package org.apache.flex.utils
{
return uint.MAX_VALUE;
}
- if (stringValue.charAt(0) == '#')
+ if (stringValue.charAt(0) === '#')
{
- if (stringValue.length == 4)
+ if (stringValue.length === 4)
return uint("0x" + stringValue.charAt(1) + stringValue.charAt(1) +
stringValue.charAt(2) + stringValue.charAt(2) +
stringValue.charAt(3) + stringValue.charAt(3));
- if (stringValue.length == 7)
+ if (stringValue.length === 7)
return uint("0xFF" + stringValue.substr(1));
return uint("0x" + stringValue.substr(1));
}
- else if ((c = stringValue.indexOf("rgb(")) != -1)
+ else if ((c = stringValue.indexOf("rgb(")) !== -1)
{
c2 = stringValue.indexOf(")");
stringValue = stringValue.substring(c + 4, c2);
@@ -143,7 +143,7 @@ package org.apache.flex.utils
(uint(parts3[1]) << 8) +
uint(parts3[2]));
}
- else if ((c = stringValue.indexOf("rgba(")) != -1)
+ else if ((c = stringValue.indexOf("rgba(")) !== -1)
{
c2 = stringValue.indexOf(")");
stringValue = stringValue.substring(c + 5, c2);
@@ -295,7 +295,7 @@ package org.apache.flex.utils
switch (side)
{
case 2:
- side = n == 2 ? 0 : 2;
+ side = n === 2 ? 0 : 2;
break;
case 3:
side = n < 3 ? 1 : 3;
[6/7] git commit: [flex-asjs] [refs/heads/develop] - missing ;
Posted by jm...@apache.org.
missing ;
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/bdbffb82
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/bdbffb82
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/bdbffb82
Branch: refs/heads/develop
Commit: bdbffb82be8c61e62d076238af43a7d9f1ed93b8
Parents: fe68c41
Author: Justin Mclean <jm...@apache.org>
Authored: Thu Jun 1 13:24:07 2017 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Thu Jun 1 13:24:07 2017 +1000
----------------------------------------------------------------------
.../Core/src/main/flex/org/apache/flex/utils/StringUtil.as | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/bdbffb82/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
index 6a8e371..180efe6 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
@@ -292,7 +292,7 @@ package org.apache.flex.utils
for (var i:int = 0; i < n; i++)
{
- code = restrict.charCodeAt(i)
+ code = restrict.charCodeAt(i);
var acceptCode:Boolean = false;
if (!inBackSlash)
[3/7] git commit: [flex-asjs] [refs/heads/develop] - make colour map
const
Posted by jm...@apache.org.
make colour map const
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/ee3a98ec
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/ee3a98ec
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/ee3a98ec
Branch: refs/heads/develop
Commit: ee3a98ecf4711a8ac0bb17b5173ec5106da0615a
Parents: 53eeff4
Author: Justin Mclean <jm...@apache.org>
Authored: Thu Jun 1 13:14:41 2017 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Thu Jun 1 13:14:41 2017 +1000
----------------------------------------------------------------------
.../Core/src/main/flex/org/apache/flex/utils/CSSUtils.as | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/ee3a98ec/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
index 0dcad67..39dc818 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
@@ -119,7 +119,7 @@ package org.apache.flex.utils
var c2:int;
var stringValue:String = value as String;
- if (stringValue == "transparent")
+ if (stringValue === "transparent")
{
return uint.MAX_VALUE;
}
@@ -316,7 +316,7 @@ package org.apache.flex.utils
* @playerversion AIR 2.6
* @productversion FlexJS 0.0
*/
- public static var colorMap:Object = {
+ public static const colorMap:Object = {
transparent: 0,
white: 0xFFFFFFFF,
silver: 0xFFC0C0C0,
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> if(typeof a !== 'undefined') {
> }
Are we really concerned that undefined may of been redefined? (Which would probably cause a whole lot of issues.)
Seems it may be a little expensive to me compared to a straight === undefined.
Thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by piotrz <pi...@gmail.com>.
I'm not sure whether I understand your answer.
I don't actually talking about checking between null or undefined - cause
it's obvious it is depends on scenario.
I'm talking about a way in which we are doing it - What do you thing to use
this "typeof a". ?
Thanks,
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-7-7-git-commit-flex-asjs-refs-heads-develop-make-getValue-a-lot-faster-30ms-down-to-5ms-in-a-compe-tp61974p62018.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> if(typeof a !== 'undefined') {
> }
>
> And of course if we consider null:
>
> if(typeof a !== 'undefined' && null !== a) {
> }
>
> Thoughts ?
It’s really going to depend on the context / code.
In some case it will be obvious with one to check. In others we may need to change the code to make it clear which values are valid.
Thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by piotrz <pi...@gmail.com>.
Justin,
It it was discussed and the other were agree for the warnings can you raise
a jira to remove them later on ?
Additional things I was speaking a bit with colleagues from JS team in my
company and asking them about checking "undefined" things. They were saying
that they are checking such things in that way:
if(typeof a !== 'undefined') {
}
And of course if we consider null:
if(typeof a !== 'undefined' && null !== a) {
}
Thoughts ?
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-7-7-git-commit-flex-asjs-refs-heads-develop-make-getValue-a-lot-faster-30ms-down-to-5ms-in-a-compe-tp61974p62016.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by ju...@classsoftware.com.
Hi,
> No reason to be :-) Knowing what evacuates to true with == and false with != is hard to remember and get right.
Evaluates was meant obviously. Autocorrect can sometime give amusing results.
thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Ahh!! You are right. Stupid. Sorry about that.
No reason to be :-) Knowing what evacuates to true with == and false with != is hard to remember and get right.
Thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by piotrz <pi...@gmail.com>.
Ahh!! You are right. Stupid. Sorry about that.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-7-7-git-commit-flex-asjs-refs-heads-develop-make-getValue-a-lot-faster-30ms-down-to-5ms-in-a-compe-tp61974p62045.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> if(styleable.style !== 'undefined' && styleable.style != null)
>
> You will have both cases handled.
(styleable.style != null) will cover both cases as well - and probably a few you may not want :-)
Until we sort out the way to do this I've just put in something that worked on both platforms.
Thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by piotrz <pi...@gmail.com>.
Hi Justin,
I saw your commit. Why in that case you cannot have?
if(styleable.style !== 'undefined' && styleable.style != null)
You will have both cases handled.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-7-7-git-commit-flex-asjs-refs-heads-develop-make-getValue-a-lot-faster-30ms-down-to-5ms-in-a-compe-tp61974p62039.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Josh Tynjala <jo...@gmail.com>.
Another place where things differ is member variables:
public var a:String;
On the SWF side, this variable defaults to null. On the JS side, it
defaults to undefined right now.
In the case of a member variable, we could set it to null by default on the
JS side to make it more consistent.
For your case, it's a little more tricky, though. Maybe something like
this, if the type on the left side is anything except *? (Numbers and
boolean would need special behavior too, though)
var propA:Object = a.prop || null;
That could have memory or performance implications. Sometimes, trying to
achieve perfect behavior parity can be too expensive. Needs benchmarking
and careful analysis to see if it's worth it, I guess!
- Josh
On Jun 2, 2017 5:20 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
Hi,
OK the issue is that we getting different results for AS and JS.
For code like this:
var a:Object = {};
var propA:Object = a.prop;
var propB:* = a.prop;
if (propA === undefined) {
trace("A undefined");
}
if (propA === null) {
trace("A null");
}
if (propB === undefined) {
trace("B undefined");
}
if (propB === null) {
trace("B null");
}
On AS we get:
A null
B undefined
On JS we get:
A undefined
B undefined
Which is obvious when you look at the generated code:
var /** @type {Object} */ a = {};
var /** @type {Object} */ propA = a.prop;
var /** @type {*} */ propB = a.prop;
So I’m guessing the compiler should be doing something different with this
line?
var /** @type {Object} */ propA = a.prop;
So it returns null rather than undefined?
Thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
OK the issue is that we getting different results for AS and JS.
For code like this:
var a:Object = {};
var propA:Object = a.prop;
var propB:* = a.prop;
if (propA === undefined) {
trace("A undefined");
}
if (propA === null) {
trace("A null");
}
if (propB === undefined) {
trace("B undefined");
}
if (propB === null) {
trace("B null");
}
On AS we get:
A null
B undefined
On JS we get:
A undefined
B undefined
Which is obvious when you look at the generated code:
var /** @type {Object} */ a = {};
var /** @type {Object} */ propA = a.prop;
var /** @type {*} */ propB = a.prop;
So I’m guessing the compiler should be doing something different with this line?
var /** @type {Object} */ propA = a.prop;
So it returns null rather than undefined?
Thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by piotrz <pi...@gmail.com>.
Justin,
I just pushed fix and it should build both version.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-7-7-git-commit-flex-asjs-refs-heads-develop-make-getValue-a-lot-faster-30ms-down-to-5ms-in-a-compe-tp61974p62031.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> I didn't run it in the browser. I run swf in Flash Player projector [1].
How are you compiling that? Looks like "mvn compile” only produces the JS version.
Thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by piotrz <pi...@gmail.com>.
I didn't run it in the browser. I run swf in Flash Player projector [1].
[1] http://www.adobe.com/support/flashplayer/debug_downloads.html
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-7-7-git-commit-flex-asjs-refs-heads-develop-make-getValue-a-lot-faster-30ms-down-to-5ms-in-a-compe-tp61974p62028.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
>> 2) I build "DataBindingExampleWithFlexLayout" and run swf version and I see
>> Null Pointer Exception in SimpleCSSValuesImpl.
>
> That I’ll take a look at.
It’s running file here for me. What browser / what was the error you were getting?
Thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> 1) I see following warnings [1].
The warnings are fine or rather the compiler shouldn’t be warning there - this has been discussed before on the list.
> 2) I build "DataBindingExampleWithFlexLayout" and run swf version and I see
> Null Pointer Exception in SimpleCSSValuesImpl.
That I’ll take a look at.
Thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by piotrz <pi...@gmail.com>.
Hi Justin,
I just tried develop and build framework.
1) I see following warnings [1].
2) I build "DataBindingExampleWithFlexLayout" and run swf version and I see
Null Pointer Exception in SimpleCSSValuesImpl.
<http://apache-flex-development.2333347.n4.nabble.com/file/n62014/npe_simplecssvaluesimpl.png>
[1] https://paste.apache.org/oexm
Could you please take a look into that ? It seems to be related to your
changes from this commit.
Thanks,
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-7-7-git-commit-flex-asjs-refs-heads-develop-make-getValue-a-lot-faster-30ms-down-to-5ms-in-a-compe-tp61974p62014.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> What will happen if some of those values will be null ? For example styleable.style ?
Styleable could be I guess but there wasn’t a null check for it before.
Styable.style is unlikely to be null. All test still pass and I’ve tested this with several applications and it never has a null value and there no code in the framework that sets it to null that I could see. The code is significantly faster.
In the other case you are looking a property that's likely to be a string /number so it will exist or not exists, comparing via == or != or if(o) is dangerous as it matches or doesn’t match all sort of things you may not expect.
But as AS and JS behaves a little differently here it would be good to have a discussion on how we should treat null/undefined.
Thanks,
Justin
Re: [7/7] git commit: [flex-asjs] [refs/heads/develop] - make
getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Justin
What will happen if some of those values will be null ? For example
styleable.style ?
Piotr
2017-06-01 7:58 GMT+02:00 <jm...@apache.org>:
> make getValue a lot faster - 30ms down to 5ms in a complex app for JS in
> Chrome
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/5e0d3305
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/5e0d3305
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/5e0d3305
>
> Branch: refs/heads/develop
> Commit: 5e0d33052ad6105cd92b18e1ce800674ce1ccec9
> Parents: bdbffb8
> Author: Justin Mclean <jm...@apache.org>
> Authored: Thu Jun 1 15:58:01 2017 +1000
> Committer: Justin Mclean <jm...@apache.org>
> Committed: Thu Jun 1 15:58:01 2017 +1000
>
> ----------------------------------------------------------------------
> .../org/apache/flex/core/SimpleCSSValuesImpl.as | 43 ++++++++------------
> 1 file changed, 18 insertions(+), 25 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> 5e0d3305/frameworks/projects/Core/src/main/flex/org/apache/
> flex/core/SimpleCSSValuesImpl.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as
> b/frameworks/projects/Core/src/main/flex/org/apache/flex/
> core/SimpleCSSValuesImpl.as
> index 6d4adec..a4e4e1d 100644
> --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/
> core/SimpleCSSValuesImpl.as
> +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/
> core/SimpleCSSValuesImpl.as
> @@ -99,8 +99,8 @@ package org.apache.flex.core
> while (true)
> {
> var ffName:String = "factoryFunctions" + i.toString();
> - var ff:Object = c[ffName];
> - if (ff === null)
> + var ff:* = c[ffName];
> + if (ff === undefined)
> break;
> generateCSSStyleDeclarations(c[ffName], c["data" +
> i.toString()]);
> if (hasEventListener("init"))
> @@ -164,9 +164,7 @@ package org.apache.flex.core
> COMPILE::SWF
> public function generateCSSStyleDeclarations(factoryFunctions:Object,
> arr:Array):void
> {
> - if (factoryFunctions === null)
> - return;
> - if (arr === null)
> + if (factoryFunctions === null || arr === null)
> return;
>
> var declarationName:String = "";
> @@ -331,30 +329,25 @@ package org.apache.flex.core
> }
>
> var value:*;
> - var o:Object;
> + var o:*;
> var className:String;
> var selectorName:String;
>
> if (thisObject is IStyleableObject)
> {
> var styleable:IStyleableObject =
> IStyleableObject(thisObject);
> - if (styleable.style !== null)
> + if (styleable.style !== undefined)
> {
> - try {
> - value = styleable.style[valueName];
> - }
> - catch (e:Error) {
> - value = undefined;
> - }
> + value = styleable.style[valueName];
> if (value === INHERIT)
> return getInheritingValue(thisObject, valueName,
> state, attrs);
> if (value !== undefined)
> return value;
> }
> - if (styleable.id !== null)
> + if (styleable.id !== undefined)
> {
> o = values["#" + styleable.id];
> - if (o)
> + if (o !== undefined)
> {
> value = o[valueName];
> if (value === INHERIT)
> @@ -364,16 +357,16 @@ package org.apache.flex.core
> }
> }
> var classNames:String =
> styleable.className;
> - if (classNames)
> + if (classNames !== undefined)
> {
> var classNameList:Array = classNames.split(" ");
> for each (className in classNameList)
> {
> - if (state)
> + if (state !== null)
> {
> selectorName = className + ":" + state;
> o = values["." + selectorName];
> - if (o)
> + if (o !== undefined)
> {
> value = o[valueName];
> if (value === INHERIT)
> @@ -384,7 +377,7 @@ package org.apache.flex.core
> }
>
> o = values["." + className];
> - if (o)
> + if (o !== undefined)
> {
> value = o[valueName];
> if (value === INHERIT)
> @@ -407,11 +400,11 @@ package org.apache.flex.core
> var thisInstance:Object = thisObject;
> while (className !== "Object")
> {
> - if (state)
> + if (state !== null)
> {
> selectorName = className + ":" +
> state;
> o = values[selectorName];
> - if (o)
> + if (o !== undefined)
> {
> value = o[valueName];
> if (value === INHERIT)
> @@ -422,7 +415,7 @@ package org.apache.flex.core
> }
>
> o = values[className];
> - if (o)
> + if (o !== undefined)
> {
> value = o[valueName];
> if (value === INHERIT)
> @@ -446,7 +439,7 @@ package org.apache.flex.core
> }
> }
>
> - if (inheritingStyles[valueName] != null &&
> + if (inheritingStyles[valueName] !== undefined &&
> thisObject is IChild)
> {
> var parentObject:Object = IChild(thisObject).parent;
> @@ -455,14 +448,14 @@ package org.apache.flex.core
> }
>
> o = values["global"];
> - if (o)
> + if (o !== undefined)
> {
> value = o[valueName];
> if (value !== undefined)
> return value;
> }
> o = values["*"];
> - if(o)
> + if (o !== undefined)
> {
> return o[valueName];
> }
>
>
[7/7] git commit: [flex-asjs] [refs/heads/develop] - make getValue a
lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Posted by jm...@apache.org.
make getValue a lot faster - 30ms down to 5ms in a complex app for JS in Chrome
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/5e0d3305
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/5e0d3305
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/5e0d3305
Branch: refs/heads/develop
Commit: 5e0d33052ad6105cd92b18e1ce800674ce1ccec9
Parents: bdbffb8
Author: Justin Mclean <jm...@apache.org>
Authored: Thu Jun 1 15:58:01 2017 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Thu Jun 1 15:58:01 2017 +1000
----------------------------------------------------------------------
.../org/apache/flex/core/SimpleCSSValuesImpl.as | 43 ++++++++------------
1 file changed, 18 insertions(+), 25 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/5e0d3305/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as
index 6d4adec..a4e4e1d 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/core/SimpleCSSValuesImpl.as
@@ -99,8 +99,8 @@ package org.apache.flex.core
while (true)
{
var ffName:String = "factoryFunctions" + i.toString();
- var ff:Object = c[ffName];
- if (ff === null)
+ var ff:* = c[ffName];
+ if (ff === undefined)
break;
generateCSSStyleDeclarations(c[ffName], c["data" + i.toString()]);
if (hasEventListener("init"))
@@ -164,9 +164,7 @@ package org.apache.flex.core
COMPILE::SWF
public function generateCSSStyleDeclarations(factoryFunctions:Object, arr:Array):void
{
- if (factoryFunctions === null)
- return;
- if (arr === null)
+ if (factoryFunctions === null || arr === null)
return;
var declarationName:String = "";
@@ -331,30 +329,25 @@ package org.apache.flex.core
}
var value:*;
- var o:Object;
+ var o:*;
var className:String;
var selectorName:String;
if (thisObject is IStyleableObject)
{
var styleable:IStyleableObject = IStyleableObject(thisObject);
- if (styleable.style !== null)
+ if (styleable.style !== undefined)
{
- try {
- value = styleable.style[valueName];
- }
- catch (e:Error) {
- value = undefined;
- }
+ value = styleable.style[valueName];
if (value === INHERIT)
return getInheritingValue(thisObject, valueName, state, attrs);
if (value !== undefined)
return value;
}
- if (styleable.id !== null)
+ if (styleable.id !== undefined)
{
o = values["#" + styleable.id];
- if (o)
+ if (o !== undefined)
{
value = o[valueName];
if (value === INHERIT)
@@ -364,16 +357,16 @@ package org.apache.flex.core
}
}
var classNames:String = styleable.className;
- if (classNames)
+ if (classNames !== undefined)
{
var classNameList:Array = classNames.split(" ");
for each (className in classNameList)
{
- if (state)
+ if (state !== null)
{
selectorName = className + ":" + state;
o = values["." + selectorName];
- if (o)
+ if (o !== undefined)
{
value = o[valueName];
if (value === INHERIT)
@@ -384,7 +377,7 @@ package org.apache.flex.core
}
o = values["." + className];
- if (o)
+ if (o !== undefined)
{
value = o[valueName];
if (value === INHERIT)
@@ -407,11 +400,11 @@ package org.apache.flex.core
var thisInstance:Object = thisObject;
while (className !== "Object")
{
- if (state)
+ if (state !== null)
{
selectorName = className + ":" + state;
o = values[selectorName];
- if (o)
+ if (o !== undefined)
{
value = o[valueName];
if (value === INHERIT)
@@ -422,7 +415,7 @@ package org.apache.flex.core
}
o = values[className];
- if (o)
+ if (o !== undefined)
{
value = o[valueName];
if (value === INHERIT)
@@ -446,7 +439,7 @@ package org.apache.flex.core
}
}
- if (inheritingStyles[valueName] != null &&
+ if (inheritingStyles[valueName] !== undefined &&
thisObject is IChild)
{
var parentObject:Object = IChild(thisObject).parent;
@@ -455,14 +448,14 @@ package org.apache.flex.core
}
o = values["global"];
- if (o)
+ if (o !== undefined)
{
value = o[valueName];
if (value !== undefined)
return value;
}
o = values["*"];
- if(o)
+ if (o !== undefined)
{
return o[valueName];
}
Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and
!== rather than == and !=
Posted by Alex Harui <ah...@adobe.com.INVALID>.
The same if() logic applies in ActionScript as well.
I've been caught by this one before:
If (“0”) is true
If (0) is false
-Alex
On 6/1/17, 12:44 AM, "piotrz" <pi...@gmail.com> wrote:
>Ahh So much love to JS :)
>
>
>
>-----
>Apache Flex PMC
>piotrzarzycki21@gmail.com
>--
>View this message in context:
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapache-fle
>x-development.2333347.n4.nabble.com%2FRe-4-7-git-commit-flex-asjs-refs-hea
>ds-develop-use-and-rather-than-and-tp61973p61989.html&data=02%7C01%7C%7C22
>cfd0bede6a41d1933a08d4a8c42732%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%
>7C636319007813353831&sdata=y%2FSeXdup7oujotDJEs6mCgpHfAozVShYCb%2B8NbRz4cg
>%3D&reserved=0
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use ===
and !== rather than == and !=
Posted by piotrz <pi...@gmail.com>.
Ahh So much love to JS :)
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-4-7-git-commit-flex-asjs-refs-heads-develop-use-and-rather-than-and-tp61973p61989.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and
!== rather than == and !=
Posted by Justin Mclean <ju...@classsoftware.com>.
HI,
> if(restrict) it's a good thing.
Not really a good thing in general as for instance:
if(“”) is false
if(“0”) is true
if(NaN) is false
> Thinking about what to do with null/undefined - It seems to be resolution -
> isn't it?
It casts a much wider net than just null and undefined.
> Maybe not exactly for the case, but in general?
It might be OK in this case as the empty string is treated like null but in general best to be avoided I think.
Thanks,
Justin
Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use ===
and !== rather than == and !=
Posted by piotrz <pi...@gmail.com>.
If I correct understand your links making
if(restrict) it's a good thing.
I don't understand this one "get messy fast" ? :)
Thinking about what to do with null/undefined - It seems to be resolution -
isn't it? Maybe not exactly for the case, but in general?
Thoughts?
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-4-7-git-commit-flex-asjs-refs-heads-develop-use-and-rather-than-and-tp61973p61981.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and
!== rather than == and !=
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> if (restrict) {}
Style best to be avoided IMO.
Lots of things are truthy / falsy in JS. [1] For instance empty string is false and so is NaN and it gets messy fast. [2]
Thanks,
Justin
1. https://developer.mozilla.org/en-US/docs/Glossary/Falsy
2. https://dorey.github.io/JavaScript-Equality-Table/
Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use ===
and !== rather than == and !=
Posted by piotrz <pi...@gmail.com>.
Understand. :) I'm wondering whether all cases are not resolves something
like that:
if (restrict) {}
Just thinking loud, cause I'm fine with your changes here.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-4-7-git-commit-flex-asjs-refs-heads-develop-use-and-rather-than-and-tp61973p61976.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and
!== rather than == and !=
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> What will happen if "restrict" will be undefined ?
A null restrict according to the comment mean any characters means nothing is restricted same as an empty string and that make sense.
Undefined is well undefined :-) having an undefined restrict doesn’t really make any sense so I don’t know what the expected behaviour should be.
If you do pass in undefined in it will throw an exception, perhaps it should not do that but I’m not sure.
Thanks,
Justin
Re: [4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and
!== rather than == and !=
Posted by Piotr Zarzycki <pi...@gmail.com>.
Hi Justin,
What will happen if "restrict" will be undefined ?
Piotr
2017-06-01 7:58 GMT+02:00 <jm...@apache.org>:
> use === and !== rather than == and !=
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/ce22dc67
> Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/ce22dc67
> Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/ce22dc67
>
> Branch: refs/heads/develop
> Commit: ce22dc67a26579611d0454eddbeef53a7db5d5d6
> Parents: ee3a98e
> Author: Justin Mclean <jm...@apache.org>
> Authored: Thu Jun 1 13:21:47 2017 +1000
> Committer: Justin Mclean <jm...@apache.org>
> Committed: Thu Jun 1 13:21:47 2017 +1000
>
> ----------------------------------------------------------------------
> .../flex/org/apache/flex/utils/StringUtil.as | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/
> ce22dc67/frameworks/projects/Core/src/main/flex/org/apache/
> flex/utils/StringUtil.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
> b/frameworks/projects/Core/src/main/flex/org/apache/flex/
> utils/StringUtil.as
> index 8674180..f53ba62 100644
> --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/
> utils/StringUtil.as
> +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/
> utils/StringUtil.as
> @@ -84,12 +84,12 @@ package org.apache.flex.utils
> */
> public static function substitute(str:String, ...
> rest):String
> {
> - if (str == null) return '';
> + if (str === null) return '';
>
> // Replace all of the parameters in the msg string.
> var len:uint = rest.length;
> var args:Array;
> - if (len == 1 && rest[0] is Array)
> + if (len === 1 && rest[0] is Array)
> {
> args = rest[0] as Array;
> len = args.length;
> @@ -125,7 +125,7 @@ package org.apache.flex.utils
> */
> public static function repeat(str:String, n:int):String
> {
> - if (n == 0)
> + if (n === 0)
> return "";
> var a:Array = [];
> for (var i:int = 0; i < n; i++)
> @@ -158,11 +158,11 @@ package org.apache.flex.utils
> public static function restrict(str:String,
> restrict:String):String
> {
> // A null 'restrict' string means all characters
> are allowed.
> - if (restrict == null)
> + if (restrict === null)
> return str;
>
> // An empty 'restrict' string means no characters
> are allowed.
> - if (restrict == "")
> + if (restrict === "")
> return "";
>
> // Otherwise, we need to test each character in
> 'str'
> @@ -285,7 +285,7 @@ package org.apache.flex.utils
> if (n > 0)
> {
> code = restrict.charCodeAt(0);
> - if (code == 94) // caret
> + if (code === 94) // caret
> allowIt = true;
> }
>
> @@ -296,11 +296,11 @@ package org.apache.flex.utils
> var acceptCode:Boolean = false;
> if (!inBackSlash)
> {
> - if (code == 45) // hyphen
> + if (code === 45) // hyphen
> inRange = true;
> - else if (code == 94) // caret
> + else if (code === 94) // caret
> setFlag = !setFlag;
> - else if (code == 92) // backslash
> + else if (code === 92) // backslash
> inBackSlash = true;
> else
> acceptCode = true;
> @@ -322,7 +322,7 @@ package org.apache.flex.utils
> }
> else
> {
> - if (charCode == code)
> + if (charCode === code)
> allowIt = setFlag;
> lastCode = code;
> }
>
>
[4/7] git commit: [flex-asjs] [refs/heads/develop] - use === and !==
rather than == and !=
Posted by jm...@apache.org.
use === and !== rather than == and !=
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/ce22dc67
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/ce22dc67
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/ce22dc67
Branch: refs/heads/develop
Commit: ce22dc67a26579611d0454eddbeef53a7db5d5d6
Parents: ee3a98e
Author: Justin Mclean <jm...@apache.org>
Authored: Thu Jun 1 13:21:47 2017 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Thu Jun 1 13:21:47 2017 +1000
----------------------------------------------------------------------
.../flex/org/apache/flex/utils/StringUtil.as | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/ce22dc67/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
index 8674180..f53ba62 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
@@ -84,12 +84,12 @@ package org.apache.flex.utils
*/
public static function substitute(str:String, ... rest):String
{
- if (str == null) return '';
+ if (str === null) return '';
// Replace all of the parameters in the msg string.
var len:uint = rest.length;
var args:Array;
- if (len == 1 && rest[0] is Array)
+ if (len === 1 && rest[0] is Array)
{
args = rest[0] as Array;
len = args.length;
@@ -125,7 +125,7 @@ package org.apache.flex.utils
*/
public static function repeat(str:String, n:int):String
{
- if (n == 0)
+ if (n === 0)
return "";
var a:Array = [];
for (var i:int = 0; i < n; i++)
@@ -158,11 +158,11 @@ package org.apache.flex.utils
public static function restrict(str:String, restrict:String):String
{
// A null 'restrict' string means all characters are allowed.
- if (restrict == null)
+ if (restrict === null)
return str;
// An empty 'restrict' string means no characters are allowed.
- if (restrict == "")
+ if (restrict === "")
return "";
// Otherwise, we need to test each character in 'str'
@@ -285,7 +285,7 @@ package org.apache.flex.utils
if (n > 0)
{
code = restrict.charCodeAt(0);
- if (code == 94) // caret
+ if (code === 94) // caret
allowIt = true;
}
@@ -296,11 +296,11 @@ package org.apache.flex.utils
var acceptCode:Boolean = false;
if (!inBackSlash)
{
- if (code == 45) // hyphen
+ if (code === 45) // hyphen
inRange = true;
- else if (code == 94) // caret
+ else if (code === 94) // caret
setFlag = !setFlag;
- else if (code == 92) // backslash
+ else if (code === 92) // backslash
inBackSlash = true;
else
acceptCode = true;
@@ -322,7 +322,7 @@ package org.apache.flex.utils
}
else
{
- if (charCode == code)
+ if (charCode === code)
allowIt = setFlag;
lastCode = code;
}
[5/7] git commit: [flex-asjs] [refs/heads/develop] - consistent
easier to read
Posted by jm...@apache.org.
consistent easier to read
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/fe68c41d
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/fe68c41d
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/fe68c41d
Branch: refs/heads/develop
Commit: fe68c41dec3c7b22afb957024369e81243a1724d
Parents: ce22dc6
Author: Justin Mclean <jm...@apache.org>
Authored: Thu Jun 1 13:23:11 2017 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Thu Jun 1 13:23:11 2017 +1000
----------------------------------------------------------------------
.../Core/src/main/flex/org/apache/flex/utils/StringUtil.as | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/fe68c41d/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
index f53ba62..6a8e371 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/StringUtil.as
@@ -84,8 +84,9 @@ package org.apache.flex.utils
*/
public static function substitute(str:String, ... rest):String
{
- if (str === null) return '';
-
+ if (str === null)
+ return '';
+
// Replace all of the parameters in the msg string.
var len:uint = rest.length;
var args:Array;
[2/7] git commit: [flex-asjs] [refs/heads/develop] - add missing ;
Posted by jm...@apache.org.
add missing ;
Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/53eeff43
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/53eeff43
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/53eeff43
Branch: refs/heads/develop
Commit: 53eeff433ecc681202f7839fca62aab7c87b635d
Parents: 02a1232
Author: Justin Mclean <jm...@apache.org>
Authored: Thu Jun 1 12:22:25 2017 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Thu Jun 1 12:22:25 2017 +1000
----------------------------------------------------------------------
.../projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/53eeff43/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
index 36705ba..0dcad67 100644
--- a/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
+++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/utils/CSSUtils.as
@@ -334,6 +334,6 @@ package org.apache.flex.utils
navy: 0xFF000080,
fuchsia: 0xFFFF00FF,
purple: 0xFF800080
- }
+ };
}
}