You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "freamdx (via GitHub)" <gi...@apache.org> on 2024/11/26 14:11:30 UTC
[PR] [SEDONA-682] exclude some dependencies. [sedona]
freamdx opened a new pull request, #1704:
URL: https://github.com/apache/sedona/pull/1704
* exclude some repetitive dependencies, https://github.com/apache/sedona/issues/1584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [SEDONA-682] exclude some dependencies. [sedona]
Posted by "Kontinuation (via GitHub)" <gi...@apache.org>.
Kontinuation commented on code in PR #1704:
URL: https://github.com/apache/sedona/pull/1704#discussion_r1859755917
##########
pom.xml:
##########
@@ -165,6 +165,20 @@
<artifactId>cdm-core</artifactId>
<version>${cdm.version}</version>
<scope>${cdm.scope}</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>httpclient</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ </exclusion>
Review Comment:
Note: `protobuf-java` became shaded since Spark 3.5 ([SPARK-41244](https://issues.apache.org/jira/browse/SPARK-41244)). However, protobuf is only used for the experimental [NetCDF streaming format](https://docs.unidata.ucar.edu/netcdf-java/5.6/userguide/ncstream.html) so excluding it won't affect our NetCDF support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org