You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/11 12:07:47 UTC

[GitHub] [flink] wangxlong opened a new pull request #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

wangxlong opened a new pull request #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060
 
 
   ## What is the purpose of the change
   
   Support byte array arguments for FROM_BASE64 function
   
   ## Brief change log
   
   Add byte array argument for FROM_BASE64 function
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   Add test in ScalarFunctionsTest#testFromBase64
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060#issuecomment-584620729
 
 
   <!--
   Meta data
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148370385 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   Hash:d5c4b949d365d8abb5c64afd7997a96a73cb903b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148514743 TriggerType:PUSH TriggerID:d5c4b949d365d8abb5c64afd7997a96a73cb903b
   Hash:d5c4b949d365d8abb5c64afd7997a96a73cb903b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5083 TriggerType:PUSH TriggerID:d5c4b949d365d8abb5c64afd7997a96a73cb903b
   -->
   ## CI report:
   
   * e919c3a4c8d702ad6583c004b62bed7df782ccb6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148370385) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054) 
   * d5c4b949d365d8abb5c64afd7997a96a73cb903b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148514743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5083) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wangxlong commented on a change in pull request #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
wangxlong commented on a change in pull request #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060#discussion_r378024636
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
 ##########
 @@ -906,6 +906,10 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
       "FROM_BASE64('5L2g5aW9')",
       "你好"
     )
+
+    testSqlApi(
+      "FROM_BASE64(CAST(x'6147567362473867643239796247513D' AS VARBINARY))",
+      "hello world")
 
 Review comment:
   Good Idea,  updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060#issuecomment-584620729
 
 
   <!--
   Meta data
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148370385 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   -->
   ## CI report:
   
   * e919c3a4c8d702ad6583c004b62bed7df782ccb6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148370385) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060#issuecomment-584620729
 
 
   <!--
   Meta data
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148370385 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   -->
   ## CI report:
   
   * e919c3a4c8d702ad6583c004b62bed7df782ccb6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148370385) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060#issuecomment-584620729
 
 
   <!--
   Meta data
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   -->
   ## CI report:
   
   * e919c3a4c8d702ad6583c004b62bed7df782ccb6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060#issuecomment-584620729
 
 
   <!--
   Meta data
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148370385 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   Hash:d5c4b949d365d8abb5c64afd7997a96a73cb903b Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148514743 TriggerType:PUSH TriggerID:d5c4b949d365d8abb5c64afd7997a96a73cb903b
   Hash:d5c4b949d365d8abb5c64afd7997a96a73cb903b Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5083 TriggerType:PUSH TriggerID:d5c4b949d365d8abb5c64afd7997a96a73cb903b
   -->
   ## CI report:
   
   * e919c3a4c8d702ad6583c004b62bed7df782ccb6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148370385) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054) 
   * d5c4b949d365d8abb5c64afd7997a96a73cb903b Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148514743) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5083) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong merged pull request #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060#issuecomment-584620729
 
 
   <!--
   Meta data
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148370385 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   Hash:d5c4b949d365d8abb5c64afd7997a96a73cb903b Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148514743 TriggerType:PUSH TriggerID:d5c4b949d365d8abb5c64afd7997a96a73cb903b
   Hash:d5c4b949d365d8abb5c64afd7997a96a73cb903b Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5083 TriggerType:PUSH TriggerID:d5c4b949d365d8abb5c64afd7997a96a73cb903b
   -->
   ## CI report:
   
   * e919c3a4c8d702ad6583c004b62bed7df782ccb6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148370385) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054) 
   * d5c4b949d365d8abb5c64afd7997a96a73cb903b Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148514743) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5083) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060#issuecomment-584620729
 
 
   <!--
   Meta data
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   Hash:e919c3a4c8d702ad6583c004b62bed7df782ccb6 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148370385 TriggerType:PUSH TriggerID:e919c3a4c8d702ad6583c004b62bed7df782ccb6
   Hash:d5c4b949d365d8abb5c64afd7997a96a73cb903b Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d5c4b949d365d8abb5c64afd7997a96a73cb903b
   -->
   ## CI report:
   
   * e919c3a4c8d702ad6583c004b62bed7df782ccb6 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148370385) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5054) 
   * d5c4b949d365d8abb5c64afd7997a96a73cb903b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060#issuecomment-584605609
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit e919c3a4c8d702ad6583c004b62bed7df782ccb6 (Tue Feb 11 12:10:16 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on a change in pull request #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #11060: [FLINK-15994][Table-planner-blink]Support byte array argument for FROM_BASE64 function
URL: https://github.com/apache/flink/pull/11060#discussion_r378015754
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
 ##########
 @@ -906,6 +906,10 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
       "FROM_BASE64('5L2g5aW9')",
       "你好"
     )
+
+    testSqlApi(
+      "FROM_BASE64(CAST(x'6147567362473867643239796247513D' AS VARBINARY))",
+      "hello world")
 
 Review comment:
   Could you add 2 more tests here?
   ```
   testSqlApi(
         "FROM_BASE64(x'6147567362473867643239796247513D')",
         "hello world")
   
   testSqlApi(
         "FROM_BASE64(f58)",  ==> add an additional column whose value is "5L2g5aW9".getBytes(StandardCharsets.UTF_8)
         "你好")
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services