You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/10/18 05:56:49 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request #7831: support create table without rule configuration

strongduanmu opened a new pull request #7831:
URL: https://github.com/apache/shardingsphere/pull/7831


   Ref #7733.
   
   Changes proposed in this pull request:
   - support create table without rule configuration
   - modify `CreateTableStatementMetaDataRefreshStrategy` and `DropTableStatementMetaDataRefreshStrategy` to support the unconfigured table  create and drop
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #7831: support create table without rule configuration

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #7831:
URL: https://github.com/apache/shardingsphere/pull/7831#issuecomment-711124382


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=h1) Report
   > Merging [#7831](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/c82441ba41bc9913a997147b70dbcc9dbb47ae60?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `70.58%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7831/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7831      +/-   ##
   ============================================
   - Coverage     75.02%   75.00%   -0.02%     
     Complexity      532      532              
   ============================================
     Files          1425     1425              
     Lines         22558    22571      +13     
     Branches       4037     4042       +5     
   ============================================
   + Hits          16924    16930       +6     
   - Misses         4545     4548       +3     
   - Partials       1089     1093       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pl/AlterTableStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZWZyZXNoL2ltcGwvQWx0ZXJUYWJsZVN0YXRlbWVudE1ldGFEYXRhUmVmcmVzaFN0cmF0ZWd5LmphdmE=) | `88.88% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...l/CreateIndexStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZWZyZXNoL2ltcGwvQ3JlYXRlSW5kZXhTdGF0ZW1lbnRNZXRhRGF0YVJlZnJlc2hTdHJhdGVneS5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...mpl/DropIndexStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZWZyZXNoL2ltcGwvRHJvcEluZGV4U3RhdGVtZW50TWV0YURhdGFSZWZyZXNoU3RyYXRlZ3kuamF2YQ==) | `78.57% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...nication/jdbc/JDBCDatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvSkRCQ0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/driver/executor/AbstractStatementExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9BYnN0cmFjdFN0YXRlbWVudEV4ZWN1dG9yLmphdmE=) | `42.10% <25.00%> (-2.34%)` | `0.00 <0.00> (ø)` | |
   | [.../route/engine/type/ShardingRouteEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL1NoYXJkaW5nUm91dGVFbmdpbmVGYWN0b3J5LmphdmE=) | `74.46% <55.55%> (-2.81%)` | `0.00 <0.00> (ø)` | |
   | [...r/jdbc/core/statement/ShardingSphereStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlU3RhdGVtZW50LmphdmE=) | `66.44% <62.50%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...mpl/DropTableStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZWZyZXNoL2ltcGwvRHJvcFRhYmxlU3RhdGVtZW50TWV0YURhdGFSZWZyZXNoU3RyYXRlZ3kuamF2YQ==) | `90.90% <83.33%> (-9.10%)` | `0.00 <0.00> (ø)` | |
   | [...gured/ShardingUnconfiguredTablesRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL3VuY29uZmlndXJlZC9TaGFyZGluZ1VuY29uZmlndXJlZFRhYmxlc1JvdXRpbmdFbmdpbmUuamF2YQ==) | `53.84% <100.00%> (+8.39%)` | `0.00 <0.00> (ø)` | |
   | [...l/CreateTableStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZWZyZXNoL2ltcGwvQ3JlYXRlVGFibGVTdGF0ZW1lbnRNZXRhRGF0YVJlZnJlc2hTdHJhdGVneS5qYXZh) | `88.88% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [4 more](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=footer). Last update [c82441b...98b3928](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #7831: support create table without rule configuration

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #7831:
URL: https://github.com/apache/shardingsphere/pull/7831#issuecomment-711124382


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=h1) Report
   > Merging [#7831](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/da7b8e6162ef587cec883062e0879fc3ecd1297f?el=desc) will **decrease** coverage by `0.01%`.
   > The diff coverage is `70.58%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7831/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #7831      +/-   ##
   ============================================
   - Coverage     74.89%   74.87%   -0.02%     
     Complexity      532      532              
   ============================================
     Files          1428     1428              
     Lines         22593    22599       +6     
     Branches       4049     4051       +2     
   ============================================
     Hits          16921    16921              
   - Misses         4583     4586       +3     
   - Partials       1089     1092       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pl/AlterTableStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZWZyZXNoL2ltcGwvQWx0ZXJUYWJsZVN0YXRlbWVudE1ldGFEYXRhUmVmcmVzaFN0cmF0ZWd5LmphdmE=) | `88.88% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...l/CreateIndexStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZWZyZXNoL2ltcGwvQ3JlYXRlSW5kZXhTdGF0ZW1lbnRNZXRhRGF0YVJlZnJlc2hTdHJhdGVneS5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...mpl/DropIndexStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZWZyZXNoL2ltcGwvRHJvcEluZGV4U3RhdGVtZW50TWV0YURhdGFSZWZyZXNoU3RyYXRlZ3kuamF2YQ==) | `78.57% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...nication/jdbc/JDBCDatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvSkRCQ0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ere/driver/executor/AbstractStatementExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9BYnN0cmFjdFN0YXRlbWVudEV4ZWN1dG9yLmphdmE=) | `42.10% <25.00%> (-2.34%)` | `0.00 <0.00> (ø)` | |
   | [.../route/engine/type/ShardingRouteEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL1NoYXJkaW5nUm91dGVFbmdpbmVGYWN0b3J5LmphdmE=) | `74.46% <55.55%> (-2.81%)` | `0.00 <0.00> (ø)` | |
   | [...r/jdbc/core/statement/ShardingSphereStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvc3RhdGVtZW50L1NoYXJkaW5nU3BoZXJlU3RhdGVtZW50LmphdmE=) | `66.21% <62.50%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...mpl/DropTableStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZWZyZXNoL2ltcGwvRHJvcFRhYmxlU3RhdGVtZW50TWV0YURhdGFSZWZyZXNoU3RyYXRlZ3kuamF2YQ==) | `90.90% <83.33%> (-9.10%)` | `0.00 <0.00> (ø)` | |
   | [...gured/ShardingUnconfiguredTablesRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL3JvdXRlL2VuZ2luZS90eXBlL3VuY29uZmlndXJlZC9TaGFyZGluZ1VuY29uZmlndXJlZFRhYmxlc1JvdXRpbmdFbmdpbmUuamF2YQ==) | `53.84% <100.00%> (+8.39%)` | `0.00 <0.00> (ø)` | |
   | [...l/CreateTableStatementMetaDataRefreshStrategy.java](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9yZWZyZXNoL2ltcGwvQ3JlYXRlVGFibGVTdGF0ZW1lbnRNZXRhRGF0YVJlZnJlc2hTdHJhdGVneS5qYXZh) | `88.88% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/shardingsphere/pull/7831/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=footer). Last update [da7b8e6...ec7ede8](https://codecov.io/gh/apache/shardingsphere/pull/7831?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #7831: support create table without rule configuration

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #7831:
URL: https://github.com/apache/shardingsphere/pull/7831


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org