[jira] [Work logged] (GOBBLIN-861) Skip getPartition() call to Hive Metastore when a partition already exists

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-861?focusedWorklogId=295926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295926 ]

ASF GitHub Bot logged work on GOBBLIN-861:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Aug/19 01:29
            Start Date: 16/Aug/19 01:29
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 commented on pull request #2716: [GOBBLIN-861]Skip getPartition() call to Hive Metastore when a partition already e…
URL: https://github.com/apache/incubator-gobblin/pull/2716
 
 
   …xists GOBBLIN-861
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-861
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   Add a subclass of HiveMetaStoreBasedRegister to skip compute diff when the partition already exists.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Test streaming job to make sure hove registration works well
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 295926)
            Time Spent: 10m
    Remaining Estimate: 0h

> Skip getPartition() call to Hive Metastore when a partition already exists
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-861
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-861
>             Project: Apache Gobblin
>          Issue Type: Task
>          Components: hive-registration
>            Reporter: Zihan Li
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, we compute a diff between the current partition and an already registered partition when a partition has already been registered in Hive. This is done by calling getPartition() on the Hive metastore client, which can be expensive. Since no time-varying attributes are stored in a Hive partition, diff computation (and getPartition() call) can be skipped when a partition already exists.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)