You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/07 08:28:52 UTC
[GitHub] [superset] stephenLYZ opened a new pull request, #19581: feat(viz-gallery): add search weight for viz-name
stephenLYZ opened a new pull request, #19581:
URL: https://github.com/apache/superset/pull/19581
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The current search weight is name = tags = description, so some search results sometimes don't match expectations. Here we set the search weight for name(4) > tags(2) > description(1).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### before
<img width="1110" alt="image" src="https://user-images.githubusercontent.com/11830681/162155195-c43a7d00-c92e-4e6e-a44e-98d1c94568d7.png">
### after
<img width="1105" alt="image" src="https://user-images.githubusercontent.com/11830681/162154963-28c1be09-ce18-40e8-b028-d46bbbc22512.png">
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ merged pull request #19581: feat(viz-gallery): add search weight for viz-name
Posted by GitBox <gi...@apache.org>.
stephenLYZ merged PR #19581:
URL: https://github.com/apache/superset/pull/19581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kasiazjc commented on pull request #19581: feat(viz-gallery): add search weight for viz-name
Posted by GitBox <gi...@apache.org>.
kasiazjc commented on PR #19581:
URL: https://github.com/apache/superset/pull/19581#issuecomment-1127415581
> code LGTM. @kasiazjc a little question for this. Do we need to search description on this? for example, When I searched `bar` in the search bar then the viz description with `bar` can be searched, sometimes this results confused me.
I think you are actually right - the description should not be included in the search as it is super confusing. Name and tags should be enough.
@lauderbaugh any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org