You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by le...@apache.org on 2023/11/22 06:07:52 UTC

(flink) 03/03: [FLINK-32997][table-planner][JUnit5 Migration] Module: flink-connectors (StreamingTestBase)

This is an automated email from the ASF dual-hosted git repository.

leonard pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit dcc47907354a0cd86a4d319d9cea3ad01d2104b5
Author: Jiabao Sun <ji...@xtransfer.cn>
AuthorDate: Tue Sep 12 14:18:15 2023 +0800

    [FLINK-32997][table-planner][JUnit5 Migration] Module: flink-connectors (StreamingTestBase)
---
 .../connectors/hive/HiveSinkCompactionITCase.java  | 24 ++++++++++++----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveSinkCompactionITCase.java b/flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveSinkCompactionITCase.java
index ffe22221cac..c90836d3ff4 100644
--- a/flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveSinkCompactionITCase.java
+++ b/flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveSinkCompactionITCase.java
@@ -24,31 +24,33 @@ import org.apache.flink.table.catalog.exceptions.TableNotExistException;
 import org.apache.flink.table.catalog.hive.HiveCatalog;
 import org.apache.flink.table.catalog.hive.HiveTestUtils;
 import org.apache.flink.table.planner.runtime.stream.sql.CompactionITCaseBase;
+import org.apache.flink.testutils.junit.extensions.parameterized.Parameter;
+import org.apache.flink.testutils.junit.extensions.parameterized.ParameterizedTestExtension;
+import org.apache.flink.testutils.junit.extensions.parameterized.Parameters;
 
-import org.junit.After;
-import org.junit.Before;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.extension.ExtendWith;
 
 import java.io.IOException;
 import java.util.Arrays;
 import java.util.Collection;
 
 /** Test sink file compaction of hive tables. */
-@RunWith(Parameterized.class)
-public class HiveSinkCompactionITCase extends CompactionITCaseBase {
+@ExtendWith(ParameterizedTestExtension.class)
+class HiveSinkCompactionITCase extends CompactionITCaseBase {
 
-    @Parameterized.Parameters(name = "format = {0}")
-    public static Collection<String> parameters() {
+    @Parameters(name = "format = {0}")
+    private static Collection<String> parameters() {
         return Arrays.asList("sequencefile", "parquet");
     }
 
-    @Parameterized.Parameter public String format;
+    @Parameter private String format;
 
     private HiveCatalog hiveCatalog;
 
     @Override
-    @Before
+    @BeforeEach
     public void init() throws IOException {
         hiveCatalog = HiveTestUtils.createHiveCatalog();
         tEnv().registerCatalog(hiveCatalog.getName(), hiveCatalog);
@@ -60,7 +62,7 @@ public class HiveSinkCompactionITCase extends CompactionITCaseBase {
         super.init();
     }
 
-    @After
+    @AfterEach
     public void tearDown() throws TableNotExistException {
         if (hiveCatalog != null) {
             hiveCatalog.dropTable(new ObjectPath(tEnv().getCurrentDatabase(), "sink_table"), true);