You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by kishorvpatil <gi...@git.apache.org> on 2018/09/13 19:52:36 UTC
[GitHub] storm pull request #2831: STORM-3224: Fix FLUX YAML Viewer icon location/pos...
GitHub user kishorvpatil opened a pull request:
https://github.com/apache/storm/pull/2831
STORM-3224: Fix FLUX YAML Viewer icon location/position on UI page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kishorvpatil/incubator-storm fix-flux-icon-formatting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2831
----
commit 66ce42a5620bda5a26b510cf8bde131ecb4c811e
Author: Kishor Patil <kp...@...>
Date: 2018-09-13T19:19:54Z
fix flux icon formatting
----
---
[GitHub] storm issue #2831: STORM-3224: Fix FLUX YAML Viewer icon location/position o...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2831
Sorry to pull my +1 back. On both Firefox and Chrome it looks off to me. Could you take a look at this again?
---
[GitHub] storm issue #2831: STORM-3224: Fix FLUX YAML Viewer icon location/position o...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2831
OMG, my bad.. looks like the span tag is added twice. Let me fix it..
---
[GitHub] storm issue #2831: STORM-3224: Fix FLUX YAML Viewer icon location/position o...
Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on the issue:
https://github.com/apache/storm/pull/2831
<img width="1430" alt="fixed-ui-page" src="https://user-images.githubusercontent.com/6090397/45646222-afa9d500-ba90-11e8-9651-56b153e7ce42.png">
@revans2 I fixed the position and removed duplicate space entries showing FLUX image icon.
---
[GitHub] storm pull request #2831: STORM-3224: Fix FLUX YAML Viewer icon location/pos...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2831
---