You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/03/15 01:05:30 UTC
[GitHub] zeppelin pull request #2138: [ZEPPELIN-2260] [branch-0.7] Skip node,npm inst...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2138
[ZEPPELIN-2260] [branch-0.7] Skip node,npm install and bundle when no helium package is selected
### What is this PR for?
Apply #2137 to `branch-0.7`
Zeppelin 0.7.0 installs node and npm when it first starts for Helium package.
To be installed, or to failed to be installed due to network timeout, it takes some times.
We can just create empty file when no Helium package is enabled, instead of install npm and build bundle.
See discussion https://github.com/apache/zeppelin/pull/2095#issuecomment-285447619
### What type of PR is it?
Improvement
### Todos
* [x] - skip node,npm install and bundle package when no package is selected
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2260
### How should this be tested?
When no package is selected (e.g. right after clean install Zeppelin), npm and node is no longer installed on startup.
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2260_branch-0.7
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2138
----
commit dd3b0c2d2adc1280ad39af1953ec45da0c017aea
Author: Lee moon soo <mo...@apache.org>
Date: 2017-03-15T00:56:51Z
Skip node,npm install and bundle when no helium package is selected
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2138: [ZEPPELIN-2260] [branch-0.7] Skip node,npm install and...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2138
LGTM! tested on local, now zeppelin (without local-repo) take little less time to restart.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2138: [ZEPPELIN-2260] [branch-0.7] Skip node,npm inst...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo closed the pull request at:
https://github.com/apache/zeppelin/pull/2138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2138: [ZEPPELIN-2260] [branch-0.7] Skip node,npm install and...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2138
Merge to branch-0.7 if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---