You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/08 08:51:29 UTC

[GitHub] [flink] AHeise opened a new pull request #10798: [FLINK-15355][plugins] Added parent first patterns for plugins.

AHeise opened a new pull request #10798: [FLINK-15355][plugins] Added parent first patterns for plugins.
URL: https://github.com/apache/flink/pull/10798
 
 
   Forwards port of https://github.com/apache/flink/pull/10778 . Main commit untouched and only the commit that reenables tests is dropped as they were never disabled on master.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski closed pull request #10798: [FLINK-15355][plugins] Added parent first patterns for plugins.

Posted by GitBox <gi...@apache.org>.
pnowojski closed pull request #10798: [FLINK-15355][plugins] Added parent first patterns for plugins.
URL: https://github.com/apache/flink/pull/10798
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10798: [FLINK-15355][plugins] Added parent first patterns for plugins.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10798: [FLINK-15355][plugins] Added parent first patterns for plugins.
URL: https://github.com/apache/flink/pull/10798#issuecomment-571951464
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit b3e2049026c1f90b8fe7777b4ab3e86e470e1ca6 (Wed Jan 08 08:54:25 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] pnowojski commented on issue #10798: [FLINK-15355][plugins] Added parent first patterns for plugins.

Posted by GitBox <gi...@apache.org>.
pnowojski commented on issue #10798: [FLINK-15355][plugins] Added parent first patterns for plugins.
URL: https://github.com/apache/flink/pull/10798#issuecomment-571962981
 
 
   Backported manually while merging #10778 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #10798: [FLINK-15355][plugins] Added parent first patterns for plugins.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10798: [FLINK-15355][plugins] Added parent first patterns for plugins.
URL: https://github.com/apache/flink/pull/10798#issuecomment-571964018
 
 
   <!--
   Meta data
   Hash:b3e2049026c1f90b8fe7777b4ab3e86e470e1ca6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b3e2049026c1f90b8fe7777b4ab3e86e470e1ca6
   -->
   ## CI report:
   
   * b3e2049026c1f90b8fe7777b4ab3e86e470e1ca6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services