[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6690: Combine operators: remove redundant variables and override logger in subclass

[GitBox <gi...@apache.org>]

mqliang commented on a change in pull request #6690:
URL: https://github.com/apache/incubator-pinot/pull/6690#discussion_r596476301



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/MinMaxValueBasedSelectionOrderByCombineOperator.java
##########
@@ -54,18 +53,14 @@
  */
 @SuppressWarnings({"rawtypes", "unchecked"})
 public class MinMaxValueBasedSelectionOrderByCombineOperator extends BaseCombineOperator {
+  private static final Logger LOGGER = LoggerFactory.getLogger(MinMaxValueBasedSelectionOrderByCombineOperator.class);

Review comment:
       done

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
##########
@@ -75,13 +74,6 @@ public BaseCombineOperator(List<Operator> operators, QueryContext queryContext,
     _futures = new Future[_numThreads];
   }
 
-  public BaseCombineOperator(List<Operator> operators, QueryContext queryContext, ExecutorService executorService,

Review comment:
       done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org