You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/20 13:18:58 UTC
[GitHub] themez commented on a change in pull request #7609: [FLINK-11642]
[flink-s3-fs-hadoop] Add mirrored config key for s3 endpoint
themez commented on a change in pull request #7609: [FLINK-11642] [flink-s3-fs-hadoop] Add mirrored config key for s3 endpoint
URL: https://github.com/apache/flink/pull/7609#discussion_r258476483
##########
File path: flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java
##########
@@ -51,7 +51,8 @@
private static final String[][] MIRRORED_CONFIG_KEYS = {
{ "fs.s3a.access-key", "fs.s3a.access.key" },
- { "fs.s3a.secret-key", "fs.s3a.secret.key" }
+ { "fs.s3a.secret-key", "fs.s3a.secret.key" },
+ { "fs.s3a.endpoint", "fs.s3a.endpoint" }
Review comment:
You're right, I think I made a mistake thought that only keys listed in `MIRRORED_CONFIG_KEYS` would be added to Hadoop's configuration. This modification may not be necessary, sorry to bother.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services