You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/03/30 12:46:02 UTC

[GitHub] [arrow] westonpace opened a new pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

westonpace opened a new pull request #9846:
URL: https://github.com/apache/arrow/pull/9846


   This adds a one hour timeout to the R builds.  It changes the R CI test script to use `reporter="location"` by default.  It adds a dump test logs step to the end of the build that will always dump the test output regardless of success/failure.
   
   These three changes combined will make it much easier to debug test failures in R tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-811149004


   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-810663512


   Revision: 85a06c8fa2da77deb7ceb09a9db02304360579c0
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-250](https://github.com/ursacomputing/crossbow/branches/all?query=actions-250)
   
   |Task|Status|
   |----|------|
   |conda-linux-gcc-py36-cpu-r36|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-conda-linux-gcc-py36-cpu-r36)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-conda-linux-gcc-py36-cpu-r36)|
   |conda-linux-gcc-py37-cpu-r40|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-conda-linux-gcc-py37-cpu-r40)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-conda-linux-gcc-py37-cpu-r40)|
   |conda-osx-clang-py36-r36|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-conda-osx-clang-py36-r36)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-conda-osx-clang-py36-r36)|
   |conda-osx-clang-py37-r40|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-conda-osx-clang-py37-r40)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-conda-osx-clang-py37-r40)|
   |conda-win-vs2017-py36-r36|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-conda-win-vs2017-py36-r36)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-conda-win-vs2017-py36-r36)|
   |conda-win-vs2017-py37-r40|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-conda-win-vs2017-py37-r40)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-conda-win-vs2017-py37-r40)|
   |homebrew-r-autobrew|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-250-github-homebrew-r-autobrew)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-250-github-homebrew-r-autobrew)|
   |test-r-install-local|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-250-github-test-r-install-local)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-250-github-test-r-install-local)|
   |test-r-linux-as-cran|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-250-github-test-r-linux-as-cran)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-250-github-test-r-linux-as-cran)|
   |test-r-minimal-build|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-test-r-minimal-build)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-test-r-minimal-build)|
   |test-r-rhub-ubuntu-gcc-release|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-test-r-rhub-ubuntu-gcc-release)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-test-r-rhub-ubuntu-gcc-release)|
   |test-r-rocker-r-base-latest|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-test-r-rocker-r-base-latest)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-test-r-rocker-r-base-latest)|
   |test-r-rstudio-r-base-3.6-bionic|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-test-r-rstudio-r-base-3.6-bionic)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-test-r-rstudio-r-base-3.6-bionic)|
   |test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
   |test-r-rstudio-r-base-3.6-centos8|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-test-r-rstudio-r-base-3.6-centos8)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-test-r-rstudio-r-base-3.6-centos8)|
   |test-r-rstudio-r-base-3.6-opensuse15|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-test-r-rstudio-r-base-3.6-opensuse15)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-test-r-rstudio-r-base-3.6-opensuse15)|
   |test-r-rstudio-r-base-3.6-opensuse42|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-test-r-rstudio-r-base-3.6-opensuse42)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-test-r-rstudio-r-base-3.6-opensuse42)|
   |test-r-version-compatibility|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-250-github-test-r-version-compatibility)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-250-github-test-r-version-compatibility)|
   |test-r-versions|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-250-github-test-r-versions)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-250-github-test-r-versions)|
   |test-ubuntu-18.04-r-sanitizer|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-250-azure-test-ubuntu-18.04-r-sanitizer)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-250-azure-test-ubuntu-18.04-r-sanitizer)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] lidavidm closed pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #9846:
URL: https://github.com/apache/arrow/pull/9846


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-810308939


   @jonkeane I think I've added the save test log step to all of the crossbow tasks but I'm not sure how to run those so haven't verified that at all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-811336478


   Thanks for adding those builds I missed.  Those changes look good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on a change in pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#discussion_r604150422



##########
File path: ci/scripts/r_test.sh
##########
@@ -73,7 +73,7 @@ SCRIPT="as_cran <- !identical(tolower(Sys.getenv('NOT_CRAN')), 'true')
     }
     rcmdcheck::rcmdcheck(build_args = '--no-build-vignettes', args = c('--no-manual', '--ignore-vignettes', '--run-donttest'), error_on = 'warning', check_dir = 'check')
   }"
-echo "$SCRIPT" | ${R_BIN} --no-save
+echo "$SCRIPT" | timeout -k 3600 3600 ${R_BIN} --no-save

Review comment:
       Yes, this is much better.  My initial searching on rcmdcheck didn't find any timeout arg otherwise I would have gone this route originally.

##########
File path: .github/workflows/r.yml
##########
@@ -86,6 +86,9 @@ jobs:
       - name: Dump install logs
         run: cat r/check/arrow.Rcheck/00install.out
         if: always()
+      - name: Dump test logs
+        run: cat r/check/arrow.Rcheck/tests/testthat.Rout

Review comment:
       Ah, good catch.  Fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace commented on a change in pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#discussion_r604149562



##########
File path: r/tests/testthat.R
##########
@@ -19,4 +19,4 @@ library(testthat)
 library(arrow)
 library(tibble)
 
-test_check("arrow")
+test_check("arrow", reporter="location")

Review comment:
       Done, thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-811464255


   Revision: 73641ab038bf79c59894ea2151eeccaf6d401fc0
   
   Submitted crossbow builds: [ursacomputing/crossbow @ actions-251](https://github.com/ursacomputing/crossbow/branches/all?query=actions-251)
   
   |Task|Status|
   |----|------|
   |conda-linux-gcc-py36-cpu-r36|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-conda-linux-gcc-py36-cpu-r36)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-conda-linux-gcc-py36-cpu-r36)|
   |conda-linux-gcc-py37-cpu-r40|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-conda-linux-gcc-py37-cpu-r40)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-conda-linux-gcc-py37-cpu-r40)|
   |conda-osx-clang-py36-r36|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-conda-osx-clang-py36-r36)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-conda-osx-clang-py36-r36)|
   |conda-osx-clang-py37-r40|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-conda-osx-clang-py37-r40)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-conda-osx-clang-py37-r40)|
   |conda-win-vs2017-py36-r36|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-conda-win-vs2017-py36-r36)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-conda-win-vs2017-py36-r36)|
   |conda-win-vs2017-py37-r40|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-conda-win-vs2017-py37-r40)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-conda-win-vs2017-py37-r40)|
   |homebrew-r-autobrew|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-251-github-homebrew-r-autobrew)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-251-github-homebrew-r-autobrew)|
   |test-r-install-local|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-251-github-test-r-install-local)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-251-github-test-r-install-local)|
   |test-r-linux-as-cran|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-251-github-test-r-linux-as-cran)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-251-github-test-r-linux-as-cran)|
   |test-r-minimal-build|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-test-r-minimal-build)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-test-r-minimal-build)|
   |test-r-rhub-ubuntu-gcc-release|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-test-r-rhub-ubuntu-gcc-release)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-test-r-rhub-ubuntu-gcc-release)|
   |test-r-rocker-r-base-latest|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-test-r-rocker-r-base-latest)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-test-r-rocker-r-base-latest)|
   |test-r-rstudio-r-base-3.6-bionic|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-test-r-rstudio-r-base-3.6-bionic)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-test-r-rstudio-r-base-3.6-bionic)|
   |test-r-rstudio-r-base-3.6-centos7-devtoolset-8|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-test-r-rstudio-r-base-3.6-centos7-devtoolset-8)|
   |test-r-rstudio-r-base-3.6-centos8|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-test-r-rstudio-r-base-3.6-centos8)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-test-r-rstudio-r-base-3.6-centos8)|
   |test-r-rstudio-r-base-3.6-opensuse15|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-test-r-rstudio-r-base-3.6-opensuse15)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-test-r-rstudio-r-base-3.6-opensuse15)|
   |test-r-rstudio-r-base-3.6-opensuse42|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-test-r-rstudio-r-base-3.6-opensuse42)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-test-r-rstudio-r-base-3.6-opensuse42)|
   |test-r-version-compatibility|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-251-github-test-r-version-compatibility)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-251-github-test-r-version-compatibility)|
   |test-r-versions|[![Github Actions](https://github.com/ursacomputing/crossbow/workflows/Crossbow/badge.svg?branch=actions-251-github-test-r-versions)](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-251-github-test-r-versions)|
   |test-ubuntu-18.04-r-sanitizer|[![Azure](https://dev.azure.com/ursacomputing/crossbow/_apis/build/status/ursacomputing.crossbow?branchName=actions-251-azure-test-ubuntu-18.04-r-sanitizer)](https://dev.azure.com/ursacomputing/crossbow/_build/latest?definitionId=1&branchName=actions-251-azure-test-ubuntu-18.04-r-sanitizer)|


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] westonpace edited a comment on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
westonpace edited a comment on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-811336478


   Thanks for adding those builds I missed.  Those changes look good to me. @jonkeane 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-810312366


   That should (if I haven't mis-spelled something!) run all of the r crossbow tests. 
   
   You can also run a single crossbow test with `@github-actions crossbow submit {test name as found in arrow/dev/tasks/tasks.yaml}`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
jonkeane commented on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-810310765


   @github-actions crossbow submit -g r


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] ianmcook commented on a change in pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
ianmcook commented on a change in pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#discussion_r605229142



##########
File path: r/tests/testthat.R
##########
@@ -19,4 +19,9 @@ library(testthat)
 library(arrow)
 library(tibble)
 
-test_check("arrow")
+if (identical(tolower(Sys.getenv("ARROW_R_DEV", FALSE)), "true")) {

Review comment:
       ```suggestion
   if (identical(tolower(Sys.getenv("ARROW_R_DEV", "false")), "true")) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on a change in pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#discussion_r604105222



##########
File path: r/tests/testthat.R
##########
@@ -19,4 +19,4 @@ library(testthat)
 library(arrow)
 library(tibble)
 
-test_check("arrow")
+test_check("arrow", reporter="location")

Review comment:
       The environment variable check could be something like:
   
   ```
   if (identical(tolower(Sys.getenv("ARROW_R_DEV", FALSE)), "true")) {
     arrow_reporter <- MultiReporter("check", "location")
   } else {
     arrow_reporter <- check_reporter()
   }
   test_check("arrow", reporter = arrow_reporter)
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] jonkeane commented on a change in pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
jonkeane commented on a change in pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#discussion_r604095465



##########
File path: r/tests/testthat.R
##########
@@ -19,4 +19,4 @@ library(testthat)
 library(arrow)
 library(tibble)
 
-test_check("arrow")
+test_check("arrow", reporter="location")

Review comment:
       We will probably want to make this change only happen on CI so that the standard reporter is used when we submit to CRAN. We could have this trigger on `ARROW_R_DEV` which is (almost?) always set on CI and isn't a terrible overloading of the meaning. 
   
   We also could use `reporter = MultiReporter("check", "location")` which should give us decent info in the check log, but also more detailed information for the artifact (this config basically concatenates the two reporter outputs in the output, but in reverse order)

##########
File path: ci/scripts/r_test.sh
##########
@@ -73,7 +73,7 @@ SCRIPT="as_cran <- !identical(tolower(Sys.getenv('NOT_CRAN')), 'true')
     }
     rcmdcheck::rcmdcheck(build_args = '--no-build-vignettes', args = c('--no-manual', '--ignore-vignettes', '--run-donttest'), error_on = 'warning', check_dir = 'check')
   }"
-echo "$SCRIPT" | ${R_BIN} --no-save
+echo "$SCRIPT" | timeout -k 3600 3600 ${R_BIN} --no-save

Review comment:
       I wonder if this is better or if we should add to line 74 the argument `timeout = 3600` which will timeout at the check level (and will mark the build as failed if the timeout happens).

##########
File path: .github/workflows/r.yml
##########
@@ -86,6 +86,9 @@ jobs:
       - name: Dump install logs
         run: cat r/check/arrow.Rcheck/00install.out
         if: always()
+      - name: Dump test logs
+        run: cat r/check/arrow.Rcheck/tests/testthat.Rout

Review comment:
       ```suggestion
           run: cat r/check/arrow.Rcheck/tests/testthat.Rout*
   ```
   
   _it turns out_ that if there's a test failure, the output is written to `r/check/arrow.Rcheck/tests/testthat.Rout.fail`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #9846: ARROW-12143: [CI] R builds should timeout and fail after some threshold and dump the output.

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9846:
URL: https://github.com/apache/arrow/pull/9846#issuecomment-810638539


   https://issues.apache.org/jira/browse/ARROW-12143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org