You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "mxsm (via GitHub)" <gi...@apache.org> on 2023/12/16 15:36:09 UTC
[PR] [ISSUE #4667] Fix some connectors have not been included in the package (eventmesh)
mxsm opened a new pull request, #4669:
URL: https://github.com/apache/eventmesh/pull/4669
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #4667
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
- Fix Some connectors have not been included in the package
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4667] Fix some connectors have not been included in the package (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on code in PR #4669:
URL: https://github.com/apache/eventmesh/pull/4669#discussion_r1429086033
##########
tools/third-party-licenses/licenses/java/LICENSE-ST4.txt:
##########
@@ -0,0 +1,28 @@
+Copyright (c) 2012-2022 The ANTLR Project. All rights reserved.
Review Comment:
I would like to know more. Is it necessary to add the corresponding LICENSE to each newly introduced jar package at the same time? What kind of LICENSE will be illegal?
我想了解一下。是每个新引入的jar包都需要同时加上对应的LICENSE吗？什么样的LICENSE将是不合法的？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4667] Fix some connectors have not been included in the package (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #4669:
URL: https://github.com/apache/eventmesh/pull/4669#discussion_r1429101338
##########
tools/third-party-licenses/licenses/java/LICENSE-ST4.txt:
##########
@@ -0,0 +1,28 @@
+Copyright (c) 2012-2022 The ANTLR Project. All rights reserved.
Review Comment:
License specification provided by @xwm1992 : https://www.apache.org/legal/resolved.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4667] Fix some connectors have not been included in the package (eventmesh)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4669:
URL: https://github.com/apache/eventmesh/pull/4669#issuecomment-1858852768
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4669?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`d625790`)](https://app.codecov.io/gh/apache/eventmesh/commit/d62579074d782b344179bcf25781f99f17c146d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.39% compared to head [(`da753c6`)](https://app.codecov.io/gh/apache/eventmesh/pull/4669?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 17.38%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4669 +/- ##
============================================
- Coverage 17.39% 17.38% -0.02%
Complexity 1760 1760
============================================
Files 797 797
Lines 29795 29790 -5
Branches 2578 2576 -2
============================================
- Hits 5184 5180 -4
+ Misses 24131 24128 -3
- Partials 480 482 +2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/4669?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4667] Fix some connectors have not been included in the package (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo merged PR #4669:
URL: https://github.com/apache/eventmesh/pull/4669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #4667] Fix some connectors have not been included in the package (eventmesh)
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on code in PR #4669:
URL: https://github.com/apache/eventmesh/pull/4669#discussion_r1429097158
##########
tools/third-party-licenses/licenses/java/LICENSE-ST4.txt:
##########
@@ -0,0 +1,28 @@
+Copyright (c) 2012-2022 The ANTLR Project. All rights reserved.
Review Comment:
> I would like to know more. Is it necessary to add the corresponding LICENSE to each newly introduced jar package at the same time? What kind of LICENSE will be illegal?
>
> 我想了解一下。是每个新引入的jar包都需要同时加上对应的LICENSE吗？什么样的LICENSE将是不合法的？
You can find the corresponding license in the documentation of the respective JAR package or in the project itself. It's not randomly written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #4667] Fix some connectors have not been included in the package (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #4669:
URL: https://github.com/apache/eventmesh/pull/4669#issuecomment-1858849710
Dependencies check failed. Please add known dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org