You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Robert Kanter (JIRA)" <ji...@apache.org> on 2012/09/06 21:19:08 UTC
[jira] [Created] (OOZIE-987) Fix minor bug in one of the uber jar
tests
Robert Kanter created OOZIE-987:
-----------------------------------
Summary: Fix minor bug in one of the uber jar tests
Key: OOZIE-987
URL: https://issues.apache.org/jira/browse/OOZIE-987
Project: Oozie
Issue Type: Bug
Affects Versions: trunk
Reporter: Robert Kanter
Assignee: Robert Kanter
Priority: Trivial
Fix For: trunk
In OOZIE-654, I added the ability to use uber jars from Oozie. One of the new tests has a try-catch block and is expected to throw and catch an exception but in the case where the test fails (i.e. it doesn't throw an exception) it should actually fail.
{code}
try {
actionXml = createUberJarActionXML(getNameNodeUri() + "/app/job.jar", "");
conf = ae.createBaseHadoopConf(context, actionXml);
ae.setupActionConf(conf, context, actionXml, getFsTestCaseDir());
assertEquals(getNameNodeUri() + "/app/job.jar", conf.get("oozie.mapreduce.uber.jar")); // <-- SHOULD FAIL INSTEAD OF THIS
} catch (ActionExecutorException aee) {
assertEquals("MR003", aee.getErrorCode());
assertEquals(ActionExecutorException.ErrorType.ERROR, aee.getErrorType());
assertTrue(aee.getMessage().contains("oozie.action.mapreduce.uber.jar.enable"));
assertTrue(aee.getMessage().contains("oozie.mapreduce.uber.jar"));
}
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-987) Fix minor bug in one of the uber jar
tests
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450129#comment-13450129 ]
Robert Kanter commented on OOZIE-987:
-------------------------------------
The test error is unrelated. The patch only changes one file, TestMapReduceActionExecutor, so it couldn't have broken any other tests.
(the test error was in org.apache.oozie.executor.jpa.TestCoordJobGetReadyActionsJPAExecutor.testCoordActionGet)
> Fix minor bug in one of the uber jar tests
> ------------------------------------------
>
> Key: OOZIE-987
> URL: https://issues.apache.org/jira/browse/OOZIE-987
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Trivial
> Fix For: trunk
>
> Attachments: OOZIE-987.patch
>
>
> In OOZIE-654, I added the ability to use uber jars from Oozie. One of the new tests has a try-catch block and is expected to throw and catch an exception but in the case where the test fails (i.e. it doesn't throw an exception) it should actually fail.
> {code}
> try {
> actionXml = createUberJarActionXML(getNameNodeUri() + "/app/job.jar", "");
> conf = ae.createBaseHadoopConf(context, actionXml);
> ae.setupActionConf(conf, context, actionXml, getFsTestCaseDir());
> assertEquals(getNameNodeUri() + "/app/job.jar", conf.get("oozie.mapreduce.uber.jar")); // <-- SHOULD FAIL INSTEAD OF THIS
> } catch (ActionExecutorException aee) {
> assertEquals("MR003", aee.getErrorCode());
> assertEquals(ActionExecutorException.ErrorType.ERROR, aee.getErrorType());
> assertTrue(aee.getMessage().contains("oozie.action.mapreduce.uber.jar.enable"));
> assertTrue(aee.getMessage().contains("oozie.mapreduce.uber.jar"));
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-987) Fix minor bug in one of the uber jar
tests
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450090#comment-13450090 ]
Hadoop QA commented on OOZIE-987:
---------------------------------
Testing JIRA OOZIE-987
Cleaning local svn workspace
{code}
----------------------------
+1 PATCH_APPLIES
CLEAN cleaned target directories
+1 RAW_PATCH_ANALYSIS
+1 the patch does not introduce any @author tags
+1 the patch does not introduce any tabs
+1 the patch does not introduce any trailing spaces
+1 the patch does not introduce any line longer than 132
+1 the patch does adds/modifies 1 testcase(s)
+1 RAT
+1 the patch does not seem to introduce new RAT warnings
+1 JAVADOC
+1 the patch does not seem to introduce new Javadoc warnings
+1 COMPILE
+1 HEAD compiles
+1 patch compiles
+1 the patch does not seem to introduce new javac warnings
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 908
Tests failures: 0
Tests errors: 1
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
{code}
The full output of the test-patch run is available at
https://builds.apache.org/job/oozie-trunk-precommit-build/85/
> Fix minor bug in one of the uber jar tests
> ------------------------------------------
>
> Key: OOZIE-987
> URL: https://issues.apache.org/jira/browse/OOZIE-987
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Trivial
> Fix For: trunk
>
> Attachments: OOZIE-987.patch
>
>
> In OOZIE-654, I added the ability to use uber jars from Oozie. One of the new tests has a try-catch block and is expected to throw and catch an exception but in the case where the test fails (i.e. it doesn't throw an exception) it should actually fail.
> {code}
> try {
> actionXml = createUberJarActionXML(getNameNodeUri() + "/app/job.jar", "");
> conf = ae.createBaseHadoopConf(context, actionXml);
> ae.setupActionConf(conf, context, actionXml, getFsTestCaseDir());
> assertEquals(getNameNodeUri() + "/app/job.jar", conf.get("oozie.mapreduce.uber.jar")); // <-- SHOULD FAIL INSTEAD OF THIS
> } catch (ActionExecutorException aee) {
> assertEquals("MR003", aee.getErrorCode());
> assertEquals(ActionExecutorException.ErrorType.ERROR, aee.getErrorType());
> assertTrue(aee.getMessage().contains("oozie.action.mapreduce.uber.jar.enable"));
> assertTrue(aee.getMessage().contains("oozie.mapreduce.uber.jar"));
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-987) Fix minor bug in one of the uber jar
tests
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450227#comment-13450227 ]
Alejandro Abdelnur commented on OOZIE-987:
------------------------------------------
+1
> Fix minor bug in one of the uber jar tests
> ------------------------------------------
>
> Key: OOZIE-987
> URL: https://issues.apache.org/jira/browse/OOZIE-987
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Trivial
> Fix For: trunk
>
> Attachments: OOZIE-987.patch
>
>
> In OOZIE-654, I added the ability to use uber jars from Oozie. One of the new tests has a try-catch block and is expected to throw and catch an exception but in the case where the test fails (i.e. it doesn't throw an exception) it should actually fail.
> {code}
> try {
> actionXml = createUberJarActionXML(getNameNodeUri() + "/app/job.jar", "");
> conf = ae.createBaseHadoopConf(context, actionXml);
> ae.setupActionConf(conf, context, actionXml, getFsTestCaseDir());
> assertEquals(getNameNodeUri() + "/app/job.jar", conf.get("oozie.mapreduce.uber.jar")); // <-- SHOULD FAIL INSTEAD OF THIS
> } catch (ActionExecutorException aee) {
> assertEquals("MR003", aee.getErrorCode());
> assertEquals(ActionExecutorException.ErrorType.ERROR, aee.getErrorType());
> assertTrue(aee.getMessage().contains("oozie.action.mapreduce.uber.jar.enable"));
> assertTrue(aee.getMessage().contains("oozie.mapreduce.uber.jar"));
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-987) Fix minor bug in one of the uber jar
tests
Posted by "Robert Kanter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Kanter updated OOZIE-987:
--------------------------------
Attachment: OOZIE-987.patch
> Fix minor bug in one of the uber jar tests
> ------------------------------------------
>
> Key: OOZIE-987
> URL: https://issues.apache.org/jira/browse/OOZIE-987
> Project: Oozie
> Issue Type: Bug
> Affects Versions: trunk
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Priority: Trivial
> Fix For: trunk
>
> Attachments: OOZIE-987.patch
>
>
> In OOZIE-654, I added the ability to use uber jars from Oozie. One of the new tests has a try-catch block and is expected to throw and catch an exception but in the case where the test fails (i.e. it doesn't throw an exception) it should actually fail.
> {code}
> try {
> actionXml = createUberJarActionXML(getNameNodeUri() + "/app/job.jar", "");
> conf = ae.createBaseHadoopConf(context, actionXml);
> ae.setupActionConf(conf, context, actionXml, getFsTestCaseDir());
> assertEquals(getNameNodeUri() + "/app/job.jar", conf.get("oozie.mapreduce.uber.jar")); // <-- SHOULD FAIL INSTEAD OF THIS
> } catch (ActionExecutorException aee) {
> assertEquals("MR003", aee.getErrorCode());
> assertEquals(ActionExecutorException.ErrorType.ERROR, aee.getErrorType());
> assertTrue(aee.getMessage().contains("oozie.action.mapreduce.uber.jar.enable"));
> assertTrue(aee.getMessage().contains("oozie.mapreduce.uber.jar"));
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira