You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2024/08/20 11:43:17 UTC
[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21694
Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
......................................................................
[common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
This patch removes the unused field 'Arena* arena' from the method
key_util::PushLowerBoundPrimaryKeyPredicates and does not contain any
functional changes.
Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
---
M src/kudu/common/key_util.cc
M src/kudu/common/key_util.h
M src/kudu/common/partition_pruner.cc
M src/kudu/common/scan_spec.cc
4 files changed, 13 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/21694/1
--
To view, visit http://gerrit.cloudera.org:8080/21694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21694 )
Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/21694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 21 Aug 2024 03:27:35 +0000
Gerrit-HasComments: No
[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21694 )
Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
......................................................................
[common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
This patch removes the unused field 'Arena* arena' from the method
key_util::PushLowerBoundPrimaryKeyPredicates and does not contain any
functional changes.
Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Reviewed-on: http://gerrit.cloudera.org:8080/21694
Reviewed-by: Yingchun Lai <la...@apache.org>
Reviewed-by: Mahesh Reddy <mr...@cloudera.com>
Tested-by: Yifan Zhang <ch...@163.com>
---
M src/kudu/common/key_util.cc
M src/kudu/common/key_util.h
M src/kudu/common/partition_pruner.cc
M src/kudu/common/scan_spec.cc
4 files changed, 13 insertions(+), 21 deletions(-)
Approvals:
Yingchun Lai: Looks good to me, approved
Mahesh Reddy: Looks good to me, but someone else must approve
Yifan Zhang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/21694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21694 )
Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
......................................................................
Patch Set 1:
> Patch Set 1: Verified-1
>
> Build Failed
>
> http://jenkins.kudu.apache.org/job/pre_commit/435/ : FAILURE
Unrelated test failures in org.apache.kudu.client.TestSecurity(TSAN).
--
To view, visit http://gerrit.cloudera.org:8080/21694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 21 Aug 2024 03:27:13 +0000
Gerrit-HasComments: No
[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has removed a vote on this change.
Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/21694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21694 )
Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/435/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/21694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 20 Aug 2024 12:46:34 +0000
Gerrit-HasComments: No
[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates
Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21694 )
Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/21694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 20 Aug 2024 18:17:02 +0000
Gerrit-HasComments: No
[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21694 )
Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
......................................................................
Patch Set 1:
> Patch Set 1: Code-Review+2
>
> Did you find any problem if passing the pointer?
Thanks for reviewing!
No, I just found this pointer unused in the function when reading related codes.
--
To view, visit http://gerrit.cloudera.org:8080/21694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 21 Aug 2024 03:26:39 +0000
Gerrit-HasComments: No
[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21694 )
Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/435/
--
To view, visit http://gerrit.cloudera.org:8080/21694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 20 Aug 2024 11:43:24 +0000
Gerrit-HasComments: No
[kudu-CR] [common] Remove unused field from key util::PushLowerBoundPrimaryKeyPredicates
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21694 )
Change subject: [common] Remove unused field from key_util::PushLowerBoundPrimaryKeyPredicates
......................................................................
Patch Set 1: Code-Review+2
Did you find any problem if passing the pointer?
--
To view, visit http://gerrit.cloudera.org:8080/21694
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d45194fc427f9bd193952e0637e73c24b2e16c1
Gerrit-Change-Number: 21694
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Tue, 20 Aug 2024 14:03:06 +0000
Gerrit-HasComments: No