You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/03/30 15:30:41 UTC

[GitHub] [zeppelin] Reamer commented on a change in pull request #4336: [ZEPPELIN-5699] Trim space in ConfInterpreter

Reamer commented on a change in pull request #4336:
URL: https://github.com/apache/zeppelin/pull/4336#discussion_r838684505



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/ConfInterpreter.java
##########
@@ -67,6 +67,9 @@ public InterpreterResult interpret(String st, InterpreterContext context)
       finalProperties.putAll(getProperties());
       Properties newProperties = new Properties();
       newProperties.load(new StringReader(st));
+      for (String key : newProperties.stringPropertyNames()) {

Review comment:
       Is it intentional that now the keys with and without trim are included in the list?
   If so, then a test should cover this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org