You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/04 18:09:17 UTC
[GitHub] [ozone] smengcl opened a new pull request #2499: HDDS-5542. Restore adding ozone-site.xml to default resource in OzoneConfiguration#activate
smengcl opened a new pull request #2499:
URL: https://github.com/apache/ozone/pull/2499
Please check out the description of jira https://issues.apache.org/jira/browse/HDDS-5542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #2499: HDDS-5542. Restore adding ozone-site.xml to default resource in OzoneConfiguration#activate
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #2499:
URL: https://github.com/apache/ozone/pull/2499#issuecomment-893258148
Thank you to investigate this issue @smengcl
> In rare cases, applications will not seemingly trigger OzoneConfiguration#loadDefaults
Can you please explain how this "rare" cases can happen?
As far as I see, the `loadDefaults` is part of both the constructors with one exception:
```
if (!(conf instanceof OzoneConfiguration)) {
loadDefaults();
}
```
My main concern is this part. IF (!) the first line here false in these *rare* cases, it's not only a problem with `ozone-site.xml` but a problem with all the defaults coming from the fragmented XML files. Therefore, the patch couldn't fix all the problems: some defaults will be missing.
Can you please check if this is case (as far as I understood the problem can be reproducible). We may need to fix the condition itself instead of adding the config to the defaults...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] github-actions[bot] commented on pull request #2499: HDDS-5542. Restore adding ozone-site.xml to default resource in OzoneConfiguration#activate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2499:
URL: https://github.com/apache/ozone/pull/2499#issuecomment-982147934
Thank you very much for the patch. I am closing this PR __temporarily__ as there was no activity recently and it is waiting for response from its author.
It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.
If you need ANY help to finish this PR, please [contact the community](https://github.com/apache/hadoop-ozone#contact) on the mailing list or the slack channel."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] github-actions[bot] closed pull request #2499: HDDS-5542. Restore adding ozone-site.xml to default resource in OzoneConfiguration#activate
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2499:
URL: https://github.com/apache/ozone/pull/2499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2499: HDDS-5542. Restore adding ozone-site.xml to default resource in OzoneConfiguration#activate
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2499:
URL: https://github.com/apache/ozone/pull/2499#issuecomment-963099296
/pending Can you please explain how this "rare" cases can happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] elek commented on pull request #2499: HDDS-5542. Restore adding ozone-site.xml to default resource in OzoneConfiguration#activate
Posted by GitBox <gi...@apache.org>.
elek commented on pull request #2499:
URL: https://github.com/apache/ozone/pull/2499#issuecomment-893258148
Thank you to investigate this issue @smengcl
> In rare cases, applications will not seemingly trigger OzoneConfiguration#loadDefaults
Can you please explain how this "rare" cases can happen?
As far as I see, the `loadDefaults` is part of both the constructors with one exception:
```
if (!(conf instanceof OzoneConfiguration)) {
loadDefaults();
}
```
My main concern is this part. IF (!) the first line here false in these *rare* cases, it's not only a problem with `ozone-site.xml` but a problem with all the defaults coming from the fragmented XML files. Therefore, the patch couldn't fix all the problems: some defaults will be missing.
Can you please check if this is case (as far as I understood the problem can be reproducible). We may need to fix the condition itself instead of adding the config to the defaults...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org